Use SciMLTesting v1.2 (run_tests harness)#174
Merged
ChrisRackauckas merged 1 commit intoJun 14, 2026
Conversation
Convert test/runtests.jl to the SciMLTesting v1.2 run_tests dispatcher. The GPU group declares its own sub-env and must NOT be in test_groups.toml (which drives the grouped-tests CI matrix) yet must still route on GROUP=GPU and be excluded from "All"; pure folder-discovery cannot express that, so the explicit-args form (a v1.2-supported path) is used. gpu_all.jl moved into test/GPU/ alongside its env. Added SciMLTesting to the root test target and to the GPU sub-env (with SafeTestsets + Test); dropped Pkg from the root test deps (no test file uses it; the harness owns all Pkg operations). test_groups.toml left unchanged. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ChrisRackauckas-Claude
force-pushed
the
sciml-testing-rollout
branch
from
6152091 to
da8249f
Compare
ChrisRackauckas-Claude
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts
test/runtests.jlto the SciMLTesting v1.2run_testsdispatcher.Because the
GPUgroup declares its own sub-env (test/GPU/Project.toml), must run only forGROUP=GPU, must be excluded fromAll, and must not be declared intest_groups.toml(which drives thegrouped-tests.ymlCI matrix — declaring GPU there would schedule it on non-GPU runners), pure folder-discovery (run_tests()) cannot express it: folder-discovery throws on an undeclaredGROUP=GPU. This PR therefore uses the v1.2-supported explicit-args form ofrun_tests, mirroring the RecursiveArrayTools.jl / OrdinaryDiffEq.jl conversions.Changes:
test/runtests.jl→using SciMLTesting; run_tests(; core = ..., groups = Dict("GPU" => (; env, body))). The Core thunk runs the same 12@safetestsetfiles forAll/Core; the env-bearingGPUgroup runs only forGROUP=GPUand is excluded fromAll— identical to the originalif GROUP == "All" || "Core"/if GROUP == "GPU"dispatch.test/gpu_all.jlmoved intotest/GPU/alongside its sub-env.Project.toml: addedSciMLTestingto[extras],[targets].test,[compat]; droppedPkg(no test file uses it — the harness owns allPkgops).test/GPU/Project.toml: addedSciMLTesting+SafeTestsets+Test(with compat).test/test_groups.tomlleft unchanged.Verified statically (TOML parse +
Meta.parseall) and via an end-to-end dispatch run on Julia 1.11 confirming the fired-file set perGROUP(All,Core,GPU) is identical to the pre-conversion dispatcher.Ignore until reviewed by @ChrisRackauckas.