Canonical CI: grouped-tests.yml + root test/test_groups.toml#172
Merged
ChrisRackauckas merged 1 commit intoJun 8, 2026
Merged
Conversation
Convert the root Tests.yml test workflow to the canonical thin caller of
SciML/.github grouped-tests.yml@v1, with the version/OS matrix declared once
in test/test_groups.toml. Filename and top-level `name: "Tests"` are preserved
so branch-protection status checks stay valid; `on:` triggers and
`concurrency:` are kept verbatim.
The previous matrix ran the full suite (GROUP defaulting to "All") on
version x os = {1,lts,pre} x {ubuntu-latest,macos-latest,windows-latest}.
The new test_groups.toml declares a single capitalized "Core" group on the
same version set with os = [ubuntu-latest, macos-latest, windows-latest].
runtests.jl already dispatches the identical testset list for both "All" and
"Core", so the (version, runner) coverage is reproduced exactly (9/9).
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts the root Tests.yml test workflow to the canonical thin caller of
SciML/.githubgrouped-tests.yml@v1, with the version/OS matrix declared once in a ROOTtest/test_groups.toml.Change
.github/workflows/Tests.yml: the hand-maintainedversion × osmatrix job is replaced by the thin caller:name: "Tests"are preserved so branch-protection status checks stay valid.on:triggers (pull_request/pushonmasterwithpaths-ignore: docs/**, plus the weeklyschedule) and theconcurrency:block are kept verbatim. Nowith:inputs are needed: the package reads the standardGROUPenv var,check-boundsdefault (yes), coverage default (true), andcoverage-directoriesdefault (src,ext, matchingsrc/+ext/); there are no apt packages.test/test_groups.toml(new): a single capitalizedCoregroup declaring the matrix.Matrix match: 9/9 exact
The old job ran the full suite (GROUP defaulting to
"All") onversion ∈ {1, lts, pre} × os ∈ {ubuntu-latest, macos-latest, windows-latest}= 9 cells.scripts/compute_affected_sublibraries.jl <root> --root-matrixagainst the new TOML emits exactly 9(Core, version, runner)cells covering the same{lts,1,pre} × {ubuntu, macos, windows}set.runtests.jlalready dispatches the identical testset list for both"All"and"Core"(GROUP == "All" || GROUP == "Core"), so the per-cell behavior is preserved — the only change is the dispatchedGROUPstring going from the implicitAlltoCore. The TOML and YAML both parse cleanly.Category A / QA
This repo already has
Core/GPUGROUP dispatch inruntests.jl, and QA (Aqua + ExplicitImports viaqa.jl/explicit_imports.jl) runs inline as part of theCorepath — there is no separateQAGROUP branch, so noruntests.jlchange was made and no separate QA group was added (that would require a source change). Static matrix-verify only; no QA findings.Untouched:
GPU.yml,Downgrade.yml,Documentation.yml,FormatCheck.yml,RunicSuggestions.yml,SpellCheck.yml,TagBot.yml,DocPreviewCleanup.yml,DependabotAutoMerge.yml.Ignore until reviewed by @ChrisRackauckas.