Optimizations to Discontinuity Detection Scheme#3720
Open
Shreyas-Ekanathan wants to merge 10 commits into
Open
Optimizations to Discontinuity Detection Scheme#3720Shreyas-Ekanathan wants to merge 10 commits into
Shreyas-Ekanathan wants to merge 10 commits into
Conversation
oscardssmith
reviewed
Jun 8, 2026
oscardssmith
reviewed
Jun 8, 2026
Shreyas-Ekanathan
force-pushed
the
disco-optimizations
branch
from
931262d to
c11227a
Compare
| is_disco = integrator.is_disco_step | ||
| if is_disco | ||
| integrator.is_disco_step = false | ||
| cache.nconsteps = 0 |
Contributor
Author
There was a problem hiding this comment.
because it's not a standard timestep BDF shouldn't really count this step towards its order selection logic right?
Member
There was a problem hiding this comment.
@ChrisRackauckas thoughts on this? I don't know how we want disco to interact with BDF well enough here.
Shreyas-Ekanathan
force-pushed
the
disco-optimizations
branch
from
ee7c874 to
31da61e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Optimizations:
tstopon the first identification of a discontinuity to help with step-resizing and prevent excessively large steps after finding a discontinuity. This should help us not take unreasonable steps, as Oscar suggested, and helps with error resetting after passing a discontinuity (since we are effectively in a new regime) to begin stepping anew._ode_addsteps!out of the zero_func_struct call and only call it once per discontinuity detection run