Remove stale OptimizationMOI MTK imports#1248
Merged
ChrisRackauckas merged 1 commit intoJul 8, 2026
Merged
Conversation
Avoid importing ModelingToolkitBase bindings that are not declared at import time on newer Julia versions. The module already accesses ModelingToolkitBase through the MTK alias. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should be ignored until reviewed by @ChrisRackauckas.
Summary
ModelingToolkitBaseinOptimizationMOIMTK = ModelingToolkitBasealias for public accessModelingToolkitBase.mergedefaultsis undeclared at import timeVerification
master,timeout 3600 /home/crackauc/.juliaup/bin/julia +1.13 --project=lib/OptimizationMOI -e 'using Pkg; Pkg.instantiate(); Pkg.precompile(); using OptimizationMOI; println("OptimizationMOI loaded")'loaded but emittedWARNING: Imported binding ModelingToolkitBase.mergedefaults was undeclared at import time during import to OptimizationMOI.OptimizationMOI loadedand noModelingToolkitBase.mergedefaultsundeclared-import warning.timeout 3600 /home/crackauc/.juliaup/bin/julia +1.13 --project=lib/OptimizationMOI -e 'using Pkg; Pkg.test(; julia_args=["--check-bounds=yes", "--compiled-modules=yes", "--depwarn=yes"], force_latest_compatible_version=false)': passed,Core | 40 pass, 2 broken, 42 total.