Raise Mooncake compat floor to 0.5.36 (fix Downgrade resolution)#994
Closed
ChrisRackauckas-Claude wants to merge 1 commit into
Closed
Raise Mooncake compat floor to 0.5.36 (fix Downgrade resolution)#994ChrisRackauckas-Claude wants to merge 1 commit into
ChrisRackauckas-Claude wants to merge 1 commit into
Conversation
Narrow the Mooncake [compat] entries from "0.4, 0.5" to a single latest
floor "0.5.36" in the two Project.toml files that declare Mooncake:
- lib/NonlinearSolveBase/Project.toml (Mooncake weakdep for
NonlinearSolveBaseMooncakeExt)
- test/Adjoint/Project.toml (Mooncake direct test dep)
This stops the downgrade lane from pinning an ancient Mooncake. Bumped
NonlinearSolveBase 2.31.3 -> 2.31.4 (compat narrowing = patch-level).
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Contributor
Author
|
Closing. Verified locally (ran the action's own downgrade.jl on the identical commit CI failed on) that raising the Mooncake compat floor does NOT fix the Downgrade lane. The failure is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Narrows the
Mooncake[compat]entries from"0.4, 0.5"to a single latest floor"0.5.36"in every Project.toml that declares Mooncake, so the Downgrade lane can no longer pin an ancient Mooncake (the "limit to latest Mooncake" fix for the promotion-caused DowngradeUnsatisfiablewall).Raised floors
lib/NonlinearSolveBase/Project.tomlNonlinearSolveBaseMooncakeExt)0.4, 0.50.5.36test/Adjoint/Project.toml0.4, 0.50.5.36Bumped
NonlinearSolveBase2.31.3→2.31.4(a[compat]narrowing on a weakdep is a patch-level change, not a public-API change).test/Adjointhas no version field (test env), so nothing to bump there. RootProject.tomldeclares no Mooncake.Verification (downgrade min-resolution actually resolves)
Ran the actual
julia-actions/julia-downgrade-compatdowngrade.jl(current HEAD, with the merged-test-depscreate_merged_projectpath) +StefanKarpinski/Resolver.jl(HEAD9353ca5) on Julia 1.12.6, reproducing the CI downgrade lanes on the two Mooncake-carrying projects:test/Adjoint(Mooncake in direct[deps]/[compat], non-merged--min=@depspath — the true Mooncake→Resolver path):Successfully resolved minimal versions, selecting Mooncake 0.5.36 (the new floor).lib/NonlinearSolveBase(Mooncake weakdep-only, merged[extras]/targets.testpath):Successfully resolved minimal versions. Mooncake is not in[extras]/targets.test, so it is never promoted into the merged[deps]fed to Resolver.jl.resolves_at_min = true— the downgrade min-resolution succeeds after the bump.Note: on the current Resolver.jl HEAD
9353ca5+ Julia 1.12, this repo'stest/Adjointgraph resolves at min even with the old"0.4, 0.5"floor (resolving to Mooncake 0.5.1), so the earlier fleet-wide Resolver/MooncakeUnsatisfiablewall does not reproduce for this repo's dependency-graph shape here. The floor-raise still holds the min-resolution to the latest Mooncake and does no harm.Please ignore until reviewed by @ChrisRackauckas.