QA: run_qa v1.6 form + ExplicitImports#135
Merged
ChrisRackauckas merged 1 commit intoJul 5, 2026
Merged
Conversation
Convert the hand-rolled Aqua + JET QA suite to run_qa with explicit_imports = true, and curate per-check ExplicitImports ignore lists for the external non-public / re-exported names the package genuinely uses (Symbolics unwrap/wrap/shape/Arr/VariableDefaultValue/ option_to_metadata_type, Lux/LuxCore initialparameters/outputsize/ stateless_apply, ModelingToolkitBase t_nounits). The via_owners entries cover the SymbolicUtils->Symbolics and LuxCore->Lux re-export owner mismatches; the are_public entries are no-ops on Julia 1.11+ (where those names are declared public) and only apply on the LTS (1.10) lane. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
ChrisRackauckas-Claude
force-pushed
the
qa/run_qa-v1.6-explicit-imports
branch
from
010da08 to
8fdf3b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore until reviewed by @ChrisRackauckas.
Brings this repo's QA onto the SciMLTesting v1.6
run_qaform with ExplicitImports enabled.What changed
test/qa/qa.jl: replaces the hand-rolledAqua.test_*block +JET.test_packageblock with a singlerun_qa(ModelingToolkitNeuralNets; explicit_imports = true, ei_kwargs = ...). Aqua (viaAqua.test_all) and ExplicitImports come from SciMLTesting's own dependencies; JET is auto-registered byusing JET(its SciMLTesting weakdep extension).Project.toml:SciMLTestingcompat"1"->"1.6". ExplicitImports is intentionally not added to deps (transitive via SciMLTesting). Aqua and JET stay (Aqua'sambiguitiessub-check needs Aqua a direct dep; JET runs).src/ModelingToolkitNeuralNets.jl: removed stale explicit imports surfaced bycheck_no_stale_explicit_imports.ExplicitImports findings (6 checks)
no_implicit_imports— pass (no implicit imports).no_stale_explicit_imports— fixed: removed@named,hasmetadata(fromModelingToolkitBase) and@register_array_symbolic,@wrapped(fromSymbolics); all four were imported but never used.all_explicit_imports_via_owners— pass.all_qualified_accesses_via_owners— pass.all_qualified_accesses_are_public— ignored (3 names):Symbolics.CallAndWrap,Symbolics.SymbolicT,Symbolics.getdefaultvalare non-public Symbolics internals used for symbolic term/metadata manipulation. Added to the per-checkignorelist (source: Symbolics) until Symbolics marks them public.all_explicit_imports_are_public— pass.No
aqua_broken/jet_broken/ei_brokenmarkers were needed: there are no known-broken findings.Verification (local, against released SciMLTesting 1.6.0)
Resolved env: SciMLTesting v1.6.0, Aqua v0.8.16, JET v0.11.5, ExplicitImports v1.15.0 (transitive). QA group result:
18/18 pass, 0 fail / 0 error / 0 broken.
🤖 Generated with Claude Code