Use SciMLTesting v1.2 (folder-based run_tests)#130
Merged
ChrisRackauckas merged 1 commit intoJun 14, 2026
Conversation
Convert ModelingToolkitNeuralNets.jl to the SciMLTesting v1.2 model: test/qa.jl moves into test/qa/, and runtests.jl becomes a single declarative run_tests call. The single-"All" CI matrix requires GROUP=All to run QA together with the functional tests, which folder-discovery's All (QA always excluded) cannot express, so the explicit-args form of run_tests is used (still v1.2). Per-GROUP behavior is preserved: GROUP=All runs the functional tests plus QA; GROUP=Core runs the functional tests only. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ChrisRackauckas-Claude
force-pushed
the
sciml-testing-rollout
branch
from
64edef9 to
5d5afd7
Compare
ChrisRackauckas-Claude
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert ModelingToolkitNeuralNets.jl to the SciMLTesting v1.2 model.
test/qa.jlmoves intotest/qa/(folder-model layout); the functional test files stay at the top level (Core).test/runtests.jlbecomes a single declarativerun_testscall.SciMLTestingadded to[extras],[targets].test, and[compat](= "1").The repo's CI matrix declares a single
[All]group, andGROUP=Allmust run QA together with the functional tests. Folder-discovery'sAllalways excludes QA, so that semantics is not expressible in folder-discovery; the explicit-args form ofrun_tests(still v1.2) is used. Per-GROUP behavior is preserved exactly:GROUP=Allruns the functional tests plus QA (the old default).GROUP=Coreruns the functional tests only (no QA), matching the Downgrade workflow.Verified by driving
run_testsv1.2.0 overGROUP=All/Core/QAwith stub bodies: the fired-body set matches the old dispatcher.Ignore until reviewed by @ChrisRackauckas.