Avoid hashconsing ForwardDiff dual constants in remakes#4716
Draft
ChrisRackauckas-Claude wants to merge 1 commit into
Draft
Avoid hashconsing ForwardDiff dual constants in remakes#4716ChrisRackauckas-Claude wants to merge 1 commit into
ChrisRackauckas-Claude wants to merge 1 commit into
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Member
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore until reviewed by @ChrisRackauckas.
This fixes the downstream Optimization.jl IntegrationTest failure in ModelingToolkit initialization tests where
SciMLBase.remakecould throwCannot determine ordering of Dual tags ... and Nothing. The failure is triggered after ForwardDiff-tagged symbolic constants enter SymbolicUtils hashconsing state, then initialization remake varmaps convert ForwardDiff dual values through the normalBasicSymbolicconstant path.The change keeps normal symbolic varmap conversion for ordinary values, but uses an unsafe symbolic constant wrapper for varmap values that contain
ForwardDiff.Dual, avoiding tag-order comparisons during hashconsing. The same helper is used bybuild_operating_pointand initialization remake data conversion.Local verification:
Cannot determine ordering of Dual tags ForwardDiff.Tag{...} and Nothing.GROUP=Initialization timeout 3600 /home/crackauc/.juliaup/bin/julia +1.12 --project=/home/crackauc/sandbox/tmp_20260708_165240_11300/repro/ModelingToolkit -e 'using Pkg; Pkg.test(coverage=false)'with localJULIA_DEPOT_PATHand Optimization.jle535903bf0ed6ca3aeedeafeee2879beb2dd2fd1developed.Result:
Test Summary: Initialization | 794 pass | 12 broken | 806 total | 43m34.8s;Testing ModelingToolkit tests passed.