Skip to content

propagate the cached reorder_parameters to the SCC subsystems #4697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AayushSabharwal merged 1 commit into from
Jul 1, 2026
Merged

propagate the cached reorder_parameters to the SCC subsystems #4697

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/problems/sccnonlinearproblem.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,6 +553,24 @@ function SciMLBase.SCCNonlinearProblem{iip}(

build_caches!(sys, decomposition)

# Every SCC subsystem is derived from `sys` via `subset_unknowns_observed`, which shares
# the entire parameter portion of the index cache by reference, and none of the subsystem
# constructions (`subset_system`, `_collapse_into!`) touch `ps`. The default parameter
# reordering is therefore identical between `sys` and every (merged or unmerged) subsystem.
if get_index_cache(sys) !== nothing
reorder_parameters(sys)
cached_reorder = check_mutable_cache(
sys, MTKBase.ReorderedDefaultParameters, MTKBase.ReorderedDefaultParameters, nothing
)
if cached_reorder isa MTKBase.ReorderedDefaultParameters
for subsys in decomposition.subsystems
store_to_mutable_cache!(
subsys, MTKBase.ReorderedDefaultParameters, cached_reorder
)
end
end
end

for i in eachindex(decomposition.subsystems)
cachevars = decomposition.scc_cachevars[i]
cacheexprs = decomposition.scc_cacheexprs[i]
Expand Down
Loading