Skip to content

Memoize split_indexed_var and get_stable_index #4696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AayushSabharwal merged 1 commit into from
Jul 1, 2026
+10 −2
Merged

Memoize split_indexed_var and get_stable_index #4696

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions lib/ModelingToolkitBase/src/utils.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1549,7 +1549,11 @@ const DEFAULT_STABLE_INDEX = SU.StableIndex(Int[])
Given a symbolic variable `x`, check whether it is an indexed array symbolic. If it is,
return the array and `true`. Otherwise, return `x, false`.
"""
function split_indexed_var(x::SymbolicT)
SU.@cache limit = 500_000 function split_indexed_var(x::SymbolicT)::Tuple{SymbolicT, Bool}
return _split_indexed_var(x)
end

function _split_indexed_var(x::SymbolicT)
return Moshi.Match.@match x begin
BSImpl.Term(; f, args) && if f === getindex end => (args[1], true)
BSImpl.Term(; f, args) && if f isa Operator && length(args) == 1 end => begin
Expand All @@ -1572,7 +1576,11 @@ end
Given a symbolic variable `x`, assume `split_indexed_var(x)[2]` is `true`. Return the
corresponding `SymbolicUtils.StableIndex`.
"""
function get_stable_index(x::SymbolicT)
SU.@cache limit = 500_000 function get_stable_index(x::SymbolicT)::SU.StableIndex{Int}
return _get_stable_index(x)
end

function _get_stable_index(x::SymbolicT)
return Moshi.Match.@match x begin
BSImpl.Term(; f, args) && if f === getindex end => return SU.StableIndex{Int}(x)
BSImpl.Term(; f, args) && if f isa Operator end => return get_stable_index(args[1])
Expand Down
Loading