Skip to content

use the cached reorder_parameters in a few more places #4690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AayushSabharwal merged 1 commit into from
Jul 1, 2026
+2 −4
Merged

use the cached reorder_parameters in a few more places #4690

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lib/ModelingToolkitBase/src/systems/codegen.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,10 @@ function generate_rhs(
kwargs...
)
dvs = unknowns(sys)
ps = parameters(sys; initial_parameters = true)
eqs = equations(sys)
obs = observed(sys)
u = dvs
p = reorder_parameters(sys, ps)
p = reorder_parameters(sys) # 1 arg to use the cached version
if cachesyms isa Vector{Vector{SymbolicT}}
append!(p, cachesyms)
end
Expand Down
3 changes: 1 addition & 2 deletions src/problems/sccnonlinearproblem.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,7 @@ function CacheWriter(
exprs::SCCCacheVarsExprsElT, solsyms;
eval_expression = false, eval_module = @__MODULE__, cse = true, sparse = false
)
ps = parameters(sys; initial_parameters = true)
rps = reorder_parameters(sys, ps)
rps = reorder_parameters(sys) # 1 arg to use the cached version
cache_writes = SymbolicT[]
for (i, T) in enumerate(buffer_types)
regions = SU.RegionsT()
Expand Down
Loading