Skip parameter args when rebuilding non-parameter array variables#4689
Merged
AayushSabharwal merged 1 commit intoJul 1, 2026
Merged
Conversation
`build_function_wrapper`` reconstructs scalarized array variables in two passes: the parameters (whose layout is cached and reused) and everything else (unknowns, cache vars, the independent variable). The second pass walked the parameter args as well, running split_indexed_var on every parameter symbol and then throwing the result away because parameters are already handled by the cache.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build_function_wrapperreconstructs scalarized array variables in two passes: the parameters and everything else (unknowns, cache vars, the independent variable). The second pass walked the parameter args as well, runningsplit_indexed_varon every parameter symbol and then throwing the result away because parameters are already handled by the cache.This makes
ODEProblemon a large model go fromto