Skip to content

refactor: store mm in TearingState#4668

Merged
AayushSabharwal merged 6 commits into
masterfrom
as/mm-in-ts
Jun 30, 2026
Merged

refactor: store mm in TearingState#4668
AayushSabharwal merged 6 commits into
masterfrom
as/mm-in-ts

Conversation

@AayushSabharwal

Copy link
Copy Markdown
Member

This avoids the mm being stale by the time it gets to reassembly.

@AayushSabharwal

Copy link
Copy Markdown
Member Author

Somehow none of the assertion failures reproduce locally

@github-actions

github-actions Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Benchmark Results (Julia vlts)

Time benchmarks
master a0f2812... master / a0f2812...
ODEProblem 13.7 ± 6.1 ms 9.59 ± 0.99 ms 1.43 ± 0.65
init 0.105 ± 0.035 ms 0.0933 ± 0.027 ms 1.13 ± 0.49
large_parameter_init/ODEProblem 0.0516 ± 0.016 s 0.0377 ± 0.0056 s 1.37 ± 0.48
large_parameter_init/init 0.112 ± 0.016 ms 0.101 ± 0.024 ms 1.11 ± 0.31
mtkcompile 18.6 ± 7.8 ms 13.5 ± 0.79 ms 1.38 ± 0.58
sparse_analytical_jacobian/ODEProblem 0.048 ± 0.016 s 0.0336 ± 0.0023 s 1.43 ± 0.49
sparse_analytical_jacobian/f_iip 0.07 ± 0.01 μs 0.07 ± 0.01 μs 1 ± 0.2
sparse_analytical_jacobian/f_oop 0.375 ± 0.27 ms 0.362 ± 0.0073 ms 1.03 ± 0.74
time_to_load 7.66 ± 0.59 s 6.35 ± 0.19 s 1.21 ± 0.1
Memory benchmarks
master a0f2812... master / a0f2812...
ODEProblem 31.5 k allocs: 1.93 MB 31.5 k allocs: 1.93 MB 1
init 0.416 k allocs: 0.0697 MB 0.416 k allocs: 0.0697 MB 1
large_parameter_init/ODEProblem 0.316 M allocs: 11.5 MB 0.317 M allocs: 11.5 MB 1
large_parameter_init/init 0.604 k allocs: 0.172 MB 0.604 k allocs: 0.172 MB 1
mtkcompile 0.0597 M allocs: 3.45 MB 0.0583 M allocs: 3.39 MB 1.02
sparse_analytical_jacobian/ODEProblem 0.196 M allocs: 8.31 MB 0.196 M allocs: 8.31 MB 1
sparse_analytical_jacobian/f_iip 0 allocs: 0 B 0 allocs: 0 B
sparse_analytical_jacobian/f_oop 0.634 k allocs: 19.6 kB 0.634 k allocs: 19.6 kB 1
time_to_load 0.153 k allocs: 14.6 kB 0.153 k allocs: 14.6 kB 1

@github-actions

github-actions Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Benchmark Results (Julia v1)

Time benchmarks
master ac70079... master / ac70079...
ODEProblem 8.68 ± 1.4 ms 9.87 ± 0.72 ms 0.88 ± 0.16
init 0.08 ± 0.0088 ms 0.0819 ± 0.0097 ms 0.977 ± 0.16
large_parameter_init/ODEProblem 0.0435 ± 0.0048 s 0.0442 ± 0.004 s 0.985 ± 0.14
large_parameter_init/init 0.0964 ± 0.039 ms 0.0992 ± 0.031 ms 0.972 ± 0.5
mtkcompile 12.7 ± 1.5 ms 13.6 ± 0.75 ms 0.936 ± 0.12
sparse_analytical_jacobian/ODEProblem 0.0369 ± 0.003 s 0.034 ± 0.0013 s 1.08 ± 0.098
sparse_analytical_jacobian/f_iip 0.08 ± 0.01 μs 0.08 ± 0 μs 1 ± 0.12
sparse_analytical_jacobian/f_oop 0.117 ± 0.014 ms 0.118 ± 0.012 ms 0.99 ± 0.15
time_to_load 5.87 ± 0.41 s 6.86 ± 0.69 s 0.856 ± 0.11
Memory benchmarks
master ac70079... master / ac70079...
ODEProblem 30.1 k allocs: 1.75 MB 30.1 k allocs: 1.77 MB 0.991
init 0.415 k allocs: 0.0517 MB 0.415 k allocs: 0.0517 MB 1
large_parameter_init/ODEProblem 0.329 M allocs: 12.5 MB 0.329 M allocs: 12.5 MB 1
large_parameter_init/init 0.798 k allocs: 0.151 MB 0.798 k allocs: 0.151 MB 1
mtkcompile 0.0561 M allocs: 2.75 MB 0.0547 M allocs: 2.7 MB 1.02
sparse_analytical_jacobian/ODEProblem 0.189 M allocs: 7.28 MB 0.189 M allocs: 7.28 MB 1
sparse_analytical_jacobian/f_iip 0 allocs: 0 B 0 allocs: 0 B
sparse_analytical_jacobian/f_oop 0.848 k allocs: 27 kB 0.848 k allocs: 27 kB 1
time_to_load 0.146 k allocs: 11.4 kB 0.146 k allocs: 11.4 kB 1

@AayushSabharwal AayushSabharwal force-pushed the as/mm-in-ts branch 2 times, most recently from aa4ead4 to a0f2812 Compare June 30, 2026 06:13
@AayushSabharwal AayushSabharwal merged commit af099a0 into master Jun 30, 2026
51 of 64 checks passed
@AayushSabharwal AayushSabharwal deleted the as/mm-in-ts branch June 30, 2026 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant