fix(tests): BrownFullBasicInit for KdV single-soliton test#588
Draft
ChrisRackauckas-Claude wants to merge 1 commit into
Draft
fix(tests): BrownFullBasicInit for KdV single-soliton test#588ChrisRackauckas-Claude wants to merge 1 commit into
ChrisRackauckas-Claude wants to merge 1 commit into
Conversation
Over-specified boundary derivatives leave an O(dx^2) residual that OrdinaryDiffEq CheckInit rejects (normresid ≈ 3.6e-5 > 1e-6). Initialize algebraic variables with BrownFullBasicInit, matching the Complex/schroedinger tests. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the failing master CI test group Higher_Order (all Julia versions).
KdV Single Soliton equationintest/Higher_Order/MOL_1D_HigherOrder.jlDAE initialization failed: ... normresid ≈ 3.56e-5 > abstol = 1e-6under OrdinaryDiffEq's defaultCheckInitinitializealg = BrownFullBasicInit()atsolve, matchingtest/Complex/schroedinger.jlOther tests in this file (
Test 00beam, beam-with-velocity) are unchanged. Beam-with-velocity already succeeds without special initialization.This is a minimal, test-scoped fix. A broader package-level fallback is proposed in #585.
Verification
Locally on Julia 1.10.11:
Notes
Please ignore this PR until reviewed by @ChrisRackauckas.