fix(tests): BrownFullBasicInit for PDAE Dirichlet DAE test#587
Draft
ChrisRackauckas-Claude wants to merge 1 commit into
Draft
fix(tests): BrownFullBasicInit for PDAE Dirichlet DAE test#587ChrisRackauckas-Claude wants to merge 1 commit into
ChrisRackauckas-Claude wants to merge 1 commit into
Conversation
OrdinaryDiffEq v7 defaults to CheckInit, which rejects the O(dx^2) residual of the algebraic constraint after MOL discretization. Match the existing Complex/schroedinger pattern and initialize with BrownFullBasicInit. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the failing master CI test group DAE (all Julia versions).
Dt(u(t,x)) ~ Dxx(u(t,x)), 0 ~ Dxx(v(t,x)) + sin(x), Dirichlet BCsintest/DAE/MOL_1D_PDAE.jlDAE initialization failed: ... normresid ≈ 0.0039 > abstol = 1e-6under OrdinaryDiffEq's defaultCheckInitinitializealg = BrownFullBasicInit()atsolve, matchingtest/Complex/schroedinger.jlThis is a minimal, test-scoped fix for one failing test. A broader package-level fallback is proposed in #585; this PR does not depend on that.
Verification
Locally on Julia 1.10.11:
Without the change, solve throws on initialization; with it, accuracy checks against the manufactured solution pass (
atol = 0.01).Notes
Please ignore this PR until reviewed by @ChrisRackauckas.