feat(WENO): discretizer integration for non-uniform grids#583
Merged
ChrisRackauckas merged 11 commits intoJul 6, 2026
Merged
Conversation
…ess and allocation tests
a57bc54 to
15c05b1
Compare
ChrisRackauckas
approved these changes
Jul 6, 2026
Member
|
None of the test failures are related? It's getting really difficult to review these, and some time to get to green will be required to go much further faster. |
Contributor
Author
You are absolutely right. I'm currently away from my desk, but my thought is that these failures are unrelated to the WENO changes. I will dive into the logs tonight or tomorrow to investigate these failures. I'll gladly help put together a fix or a separate PR to get the CI back to green so we can proceed smoothly. |
Member
|
Yeah let's merge but we should take a bit of time to green it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Non-uniform WENO-5 is wired into the MethodOfLines discretizer via
WENONonUniformBoundaryVal callables and grid-dispatched stencil extent. Uniform grids retain the legacyweno_f_uniformpath.Architectural Wiring
WENOScheme():{5,0}+[nothing, nothing]→{5,5}+WENONonUniformBoundary{1,2}/{5,4}lower/upper callables.extent(WENOScheme(), dorder, dx::Number) == 2;dx::AbstractVector→0— routed throughinterior_map.jlviaextent(ascheme, dorder, s.dxs[x]).scheme_types.jl: 3-argextent(scheme, dorder, dx)fallback delegates to 2-arg for grid-agnostic schemes.MethodOfLines.jl: includenonuniform_weno.jlbeforeWENO.jl(forward-ref toWENONonUniformBoundary).WENONonUniformBoundary:dx::AbstractVectoranddx::Numberdispatches (FunctionalScheme contract).Internal Breaking Changes
FunctionalScheme{5,0}, boundarynothing+ extrapolation{5,5}, Val boundary callablesextent(..., Number)==2, interiorweno_f_uniformnothingcount)dx: 3-arg extent0extent(WENOScheme(), 1) == 2extent(WENOScheme(), 1) == 0s.dxs[x](3-arg); 2-arg only affects callers omitting grid spacingStandard uniform routing is isolated:
s.dxs[x]is aNumberonStepRangeLengrids → extent2unchanged.Testing Highlights
test/Components/weno_boundary_integration.jl: extent dispatch, interior-map metadata (NU0vs uniform2),get_f_and_tapsrouting toWENONonUniformBoundary{2}/{4},@inferredboundary execution,discretize+solvesmoke (inflow Dirichlet + outflow zero-flux).weno_nonuniform_boundary.jl: 205/205 (no regression).