Non-Uniform WENO Core (Direct Derivative Reconstruction)#581
Conversation
|
Briefly, Since it's currently a node-centered, central, non-conservative core, I’d love your high-level sanity check on two quick points before I start coding the boundary cases: Boundaries: I plan to handle edge nodes via biased Fornberg stencils (dropping to 3rd-order locally, which should maintain global 4th-order per Gustafsson’s GKS theory). Does this sound like the right path? Upwinding: Since the current uniform No rush for a detailed line-by-line review just wanted to make sure the foundation is on the right track before spending time on the edge dispatches. |
| end | ||
|
|
||
| # Non-uniform node-centered Lagrange WENO-5 dispatch (struct/constructor wiring handled separately). | ||
| include("weno_nonuniform.jl") |
There was a problem hiding this comment.
all includes should be at the top level.
| # Fornberg (1988) finite-difference weights for a 3-point stencil; returns the m = 0, 1, 2 operators. | ||
| @inline function _fornberg3_weights(α::NTuple{3, T}, xt::T) where {T} |
There was a problem hiding this comment.
This is already implemented in the package?
There was a problem hiding this comment.
I actually considered using it first, but I noticed it allocates dynamic arrays internally, which causes heap allocations.I felt using the explicit algebraic form here was the safest bet to guarantee zero allocation.
…ess and allocation tests
…-allocation on LTS
c145ce0 to
2cef2b3
Compare
|
Looks good once it's out of draft. |
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.