Staggered interpolations#354
Open
cmhyett wants to merge 2 commits into
Open
Conversation
… work for periodic BCs, but otherwise seems to achieve goal
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #354 +/- ##
===========================================
- Coverage 84.99% 61.78% -23.22%
===========================================
Files 41 41
Lines 1959 1965 +6
===========================================
- Hits 1665 1214 -451
- Misses 294 751 +457 ☔ View full report in Codecov by Sentry. |
xtalax
approved these changes
Jan 22, 2024
xtalax
left a comment
xtalax
left a comment
Member
There was a problem hiding this comment.
Looks good, could use higher order interpolations though, see the nonlinear laplacian for how
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Working to fix #351. Need to utilize variable staggering for non-derivative terms. I currently implement this as a simple average between neighboring points, but in general we should leverage MoL's already built-in interpolations.
Attached are generated code before/after for gas-flow equations.
interpolation_results.txt
CI will break on this commit due to lack of support for periodic bcs, but I'll resolve it in the next.