Skip to content

Fix PureKLU Dual-A dispatch stolen by DualBLinearProblem opt-out #1073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisRackauckas merged 1 commit into from
Jul 3, 2026
Merged

Fix PureKLU Dual-A dispatch stolen by DualBLinearProblem opt-out #1073

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ext/LinearSolveForwardDiffExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,14 @@ function SciMLBase.init(prob::DualBLinearProblem, alg::PureKLUFactorization, arg
return __init(prob, alg, args...; kwargs...)
end

# DualBLinearProblem's A slot is `Union{Number, AbstractArray}`, which a Dual-eltype A
# also matches, so the b-only opt-out above would otherwise capture both-Dual problems
# (`DualLinearProblem <: DualBLinearProblem`). Restore the direct dual path for them: a
# Dual A needs the DualLinearCache machinery, the mixed-type ldiv! only covers primal A.
function SciMLBase.init(prob::DualLinearProblem, alg::PureKLUFactorization, args...; kwargs...)
return __dual_init(prob, alg, args...; kwargs...)
end

# NOTE: Removed the runtime conditional for DefaultLinearSolver that checked for
# GenericLUFactorization. Now always use __dual_init for type stability.
function SciMLBase.init(prob::DualAbstractLinearProblem, alg::DefaultLinearSolver, args...; kwargs...)
Expand Down
Loading