QA: run_qa v1.6 form + ExplicitImports (root + sublibs)

lib/LinearSolveAutotune/test/qa/Project.toml

@@ -3,6 +3,7 @@ Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
 JET = "c3a54625-cd67-489e-a8e7-0a5a0ff4e31b"
 LinearSolve = "7ed4a6bd-45f5-4d41-b270-4a48e9bafcae"
 LinearSolveAutotune = "67398393-80e8-4254-b7e4-1b9a36a3c5b6"
+SciMLTesting = "09d9d899-5365-40a9-917a-5f67fddea283"
 Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
 
 [sources]
@@ -14,5 +15,6 @@ Aqua = "0.8"
 JET = "0.9, 0.10, 0.11"
 LinearSolve = "3"
 LinearSolveAutotune = "1"
+SciMLTesting = "1.6"
 Test = "1"
 julia = "1.10"

lib/LinearSolveAutotune/test/qa/qa.jl

@@ -1,4 +1,38 @@
-using LinearSolveAutotune, Aqua, JET
+using SciMLTesting, LinearSolveAutotune, Test
+using JET
 
-Aqua.test_all(LinearSolveAutotune)
-JET.test_package(LinearSolveAutotune; target_defined_modules = true)
+run_qa(
+    LinearSolveAutotune;
+    explicit_imports = true,
+    jet_kwargs = (; target_defined_modules = true),
+    ei_kwargs = (;
+        # BlasFloat (LinearAlgebra.BLAS, reached via LinearAlgebra) and Base.run.
+        all_qualified_accesses_via_owners = (; ignore = (:BlasFloat, :run)),
+        # Non-public names accessed qualified: LinearSolve internals
+        # (get_config/get_extension/is_available/userecursivefactorization/...),
+        # Base/Pkg internals (PkgId, UUID, dependencies, loaded_modules, run, ...),
+        # and CPUSummary/blis names used by the benchmarking harness.
+        all_qualified_accesses_are_public = (;
+            ignore = (
+                :BLISLUFactorization, :BlasFloat, :GIT_VERSION_INFO, :Parameters,
+                :PkgId, :UUID, :appleaccelerate_isavailable, :dependencies, :format,
+                :functional, :get_config, :get_extension, :get_num_threads,
+                :is_available, :libm_name, :loaded_modules, :run,
+                :userecursivefactorization, :vendor,
+            ),
+        ),
+    ),
+    # Heavy `using LinearAlgebra, Statistics, Random, Printf, Base64, Plots, ...`
+    # brings ~55 names implicitly; making them explicit is a source refactor tracked
+    # in https://github.com/SciML/LinearSolve.jl/issues/1058
+    ei_broken = (:no_implicit_imports,),
+    # JET reports 8 pre-existing latent issues in the telemetry/GPU-detection
+    # source (parse/split union splits and try/catch variable-scope leaks in
+    # telemetry.jl + gpu_detection.jl). These predate this QA conversion: the
+    # prior `JET.test_package(LinearSolveAutotune; target_defined_modules=true)`
+    # call surfaced the identical 8 reports, and #1033 (which added this QA group)
+    # merged with the same QA(julia 1) lane red. Fixing them is a telemetry-source
+    # task tracked in https://github.com/SciML/LinearSolve.jl/issues/1058; mark the
+    # JET check known-broken so it auto-flags once those source bugs are fixed.
+    jet_broken = true,
+)

lib/LinearSolvePyAMG/test/qa/Project.toml

@@ -3,6 +3,7 @@ Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
 JET = "c3a54625-cd67-489e-a8e7-0a5a0ff4e31b"
 LinearSolve = "7ed4a6bd-45f5-4d41-b270-4a48e9bafcae"
 LinearSolvePyAMG = "7a56c47d-7ab1-4e99-b0e3-2952e463d64a"
+SciMLTesting = "09d9d899-5365-40a9-917a-5f67fddea283"
 Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
 
 [sources]
@@ -14,5 +15,6 @@ Aqua = "0.8"
 JET = "0.9, 0.10, 0.11"
 LinearSolve = "3"
 LinearSolvePyAMG = "1"
+SciMLTesting = "1.6"
 Test = "1"
 julia = "1.10"

lib/LinearSolvePyAMG/test/qa/qa.jl

@@ -1,4 +1,25 @@
-using LinearSolvePyAMG, Aqua, JET
+using SciMLTesting, LinearSolvePyAMG, Test
+using JET
 
-Aqua.test_all(LinearSolvePyAMG)
-JET.test_package(LinearSolvePyAMG; target_defined_modules = true)
+run_qa(
+    LinearSolvePyAMG;
+    explicit_imports = true,
+    jet_kwargs = (; target_defined_modules = true),
+    ei_kwargs = (;
+        # Non-public names accessed qualified: SciMLBase / LinearSolve internals the
+        # solver wrapper relies on (build_linear_solution, default_alias_A/b, ...).
+        all_qualified_accesses_are_public = (;
+            ignore = (
+                :SciMLLinearSolveAlgorithm, :Success, :build_linear_solution,
+                :default_alias_A, :default_alias_b, :init_cacheval,
+                :needs_concrete_A, :update_tolerances_internal!,
+            ),
+        ),
+        # LinearCache is not declared public in LinearSolve.
+        all_explicit_imports_are_public = (; ignore = (:LinearCache,)),
+    ),
+    # `using LinearAlgebra, SparseArrays, PythonCall, CondaPkg` brings several names
+    # in implicitly; making them explicit is a source refactor tracked in
+    # https://github.com/SciML/LinearSolve.jl/issues/1058
+    ei_broken = (:no_implicit_imports,),
+)

test/qa/Project.toml

@@ -1,6 +1,5 @@
 [deps]
 Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
-ExplicitImports = "7d51a73a-1435-4ff3-83d9-f097790105c7"
 JET = "c3a54625-cd67-489e-a8e7-0a5a0ff4e31b"
 LinearSolve = "7ed4a6bd-45f5-4d41-b270-4a48e9bafcae"
 SafeTestsets = "1bc83da4-3b8d-516f-aca4-4fe02f6d838f"
@@ -12,10 +11,9 @@ LinearSolve = {path = "../.."}
 
 [compat]
 Aqua = "0.8"
-ExplicitImports = "1.10"
 JET = "0.9, 0.11"
 LinearSolve = "3"
 SafeTestsets = "0.1, 1"
-SciMLTesting = "1"
+SciMLTesting = "1.6"
 Test = "<0.0.1, 1"
 julia = "1.10"

test/qa/qa.jl

@@ -1,52 +1,72 @@
-using LinearSolve, Aqua
-using ExplicitImports
-using Test
+using SciMLTesting, LinearSolve, Test
+using SparseArrays  # materializes the KLU submodule via LinearSolveSparseArraysExt
 
-@testset "Aqua" begin
-    Aqua.find_persistent_tasks_deps(LinearSolve)
-    Aqua.test_ambiguities(LinearSolve, recursive = false, broken = true)
-    Aqua.test_deps_compat(LinearSolve, ignore = [:MKL_jll])
-    Aqua.test_piracies(
-        LinearSolve,
-        treat_as_own = [LinearProblem]
-    )
-    Aqua.test_project_extras(LinearSolve)
-    Aqua.test_stale_deps(LinearSolve, ignore = [:MKL_jll])
-    Aqua.test_unbound_args(LinearSolve)
-    Aqua.test_undefined_exports(LinearSolve)
+# Extension submodules ExplicitImports cannot analyze; allow them to be unanalyzable.
+klu_mod = try
+    Base.get_extension(LinearSolve, :LinearSolveSparseArraysExt).KLU
+catch
+    nothing
+end
+unanalyzable_mods = (
+    LinearSolve.OperatorCondition, LinearSolve.DefaultAlgorithmChoice,
+    LinearSolve.NonstructuralZeros,
+)
+if klu_mod !== nothing
+    unanalyzable_mods = (unanalyzable_mods..., klu_mod)
 end
 
-@testset "Explicit Imports" begin
-    # Get extension modules that might be unanalyzable
-    klu_mod = try
-        Base.get_extension(LinearSolve, :LinearSolveSparseArraysExt).KLU
-    catch
-        nothing
-    end
-    unanalyzable_mods = (
-        LinearSolve.OperatorCondition, LinearSolve.DefaultAlgorithmChoice,
-        LinearSolve.NonstructuralZeros,
-    )
-    if klu_mod !== nothing
-        unanalyzable_mods = (unanalyzable_mods..., klu_mod)
-    end
+# SciMLLogging names pulled in by the @verbosity_specifier macro expansion, plus
+# @set! reached by extensions via LinearSolve.@set! — both look stale to EI because
+# their only uses are through macro-generated / downstream-extension code.
+sciml_logging_macro_imports = (
+    :AbstractVerbositySpecifier, :AbstractVerbosityPreset,
+    :None, :Minimal, :Standard, :Detailed, :All,
+)
+extension_imports = (Symbol("@set!"),)
 
-    @test check_no_implicit_imports(
-        LinearSolve; skip = (Base, Core),
-        allow_unanalyzable = unanalyzable_mods
-    ) === nothing
-    # These SciMLLogging imports are used by the @verbosity_specifier macro-generated code
-    # but ExplicitImports can't detect usage through macro expansions
-    sciml_logging_macro_imports = (
-        :AbstractVerbositySpecifier, :AbstractVerbosityPreset,
-        :None, :Minimal, :Standard, :Detailed, :All,
-    )
-    # @set! is used by extensions via LinearSolve.@set! but ExplicitImports can't detect this
-    extension_imports = (Symbol("@set!"),)
-    @test check_no_stale_explicit_imports(
-        LinearSolve;
-        allow_unanalyzable = unanalyzable_mods,
-        ignore = (sciml_logging_macro_imports..., extension_imports...)
-    ) === nothing
-    @test check_all_qualified_accesses_via_owners(LinearSolve) === nothing
-end
+run_qa(
+    LinearSolve;
+    explicit_imports = true,
+    # Recursive ambiguities are tracked separately; placeholder until resolved.
+    aqua_broken = (:ambiguities,),
+    aqua_kwargs = (;
+        deps_compat = (; ignore = [:MKL_jll]),
+        stale_deps = (; ignore = [:MKL_jll]),
+        piracies = (; treat_as_own = [LinearProblem]),
+    ),
+    ei_kwargs = (;
+        no_implicit_imports = (;
+            skip = (Base, Core), allow_unanalyzable = unanalyzable_mods,
+        ),
+        no_stale_explicit_imports = (;
+            allow_unanalyzable = unanalyzable_mods,
+            ignore = (sciml_logging_macro_imports..., extension_imports...),
+        ),
+        # Names imported from a re-exporting module rather than their defining owner:
+        #   @blasfunc/chkstride1 (LinearAlgebra.BLAS, via LinearAlgebra.LAPACK),
+        #   AbstractSciMLOperator (SciMLOperators, via SciMLBase),
+        #   ArrayInterface/UMFPACK_OK (re-exported), inv (Base, via LinearAlgebra).
+        all_explicit_imports_via_owners = (;
+            ignore = (
+                Symbol("@blasfunc"), :AbstractSciMLOperator, :ArrayInterface,
+                :UMFPACK_OK, :chkstride1, :inv,
+            ),
+        ),
+        # Non-public names explicitly imported from stdlib / other packages
+        # (LinearAlgebra(.BLAS/.LAPACK), SparseArrays, SciMLBase, SciMLOperators,
+        # ArrayInterface, StaticArraysCore, Base) and needed by the solver bindings.
+        all_explicit_imports_are_public = (;
+            ignore = (
+                Symbol("@blasfunc"), :AbstractSciMLOperator, :AbstractSparseMatrixCSC,
+                :ArrayInterface, :BLASELTYPES, :BlasInt, :StaticArray, :UMFPACK_OK,
+                :chkargsok, :chkfinite, :chkstride1, :getcolptr, :inv,
+                :pattern_changed, :require_one_based_indexing,
+            ),
+        ),
+    ),
+    # ~90 qualified accesses of non-public names (LinearSolve's own internals reached
+    # via LinearSolve.x from extensions, plus stdlib/SciMLBase/LinearAlgebra internals).
+    # Making them public is a large cross-package effort tracked in
+    # https://github.com/SciML/LinearSolve.jl/issues/1058
+    ei_broken = (:all_qualified_accesses_are_public,),
+)