Skip to content

Fix init_cacheval for SizedMatrix (StaticArrays.LU has no field factors) #1056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisRackauckas merged 1 commit into from
Jun 21, 2026
+8 −0
Merged

Fix init_cacheval for SizedMatrix (StaticArrays.LU has no field factors) #1056

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/factorization.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,10 @@ function LinearSolve.init_cacheval(
# type matches for dense CPU arrays whose container isn't `Base.Array`
# (e.g. `FixedSizeArray`), whose `lu_instance` pivot would otherwise differ.
luinst = ArrayInterface.lu_instance(convert(AbstractMatrix, A))
# `lu_instance` may return a non-`LinearAlgebra.LU` (e.g. `StaticArrays.LU`
# for a `SizedMatrix`, with fields `L`/`U`/`p` rather than `factors`/`info`);
# those already carry a `Vector` pivot, so use them as-is.
luinst isa LinearAlgebra.LU || return luinst, ipiv
return LinearAlgebra.LU(luinst.factors, ipiv, luinst.info), ipiv
end

Expand Down Expand Up @@ -343,6 +347,10 @@ function init_cacheval(
# (e.g. a `FixedSizeVector` for a `FixedSizeArray`), so rebuild the instance
# with the `Vector` pivot to keep the cacheval slot type matching.
luinst = ArrayInterface.lu_instance(convert(AbstractMatrix, A))
# `lu_instance` may return a non-`LinearAlgebra.LU` (e.g. `StaticArrays.LU`
# for a `SizedMatrix`, with fields `L`/`U`/`p` rather than `factors`/`info`);
# those already carry a `Vector` pivot, so use them as-is.
luinst isa LinearAlgebra.LU || return luinst, ipiv
return LinearAlgebra.LU(luinst.factors, ipiv, luinst.info), ipiv
end

Expand Down
Loading