Skip to content

Fix Core/Downgrade SuperLUDIST resolve skip and StaticArrays.LU init_cacheval regression #1053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisRackauckas merged 2 commits into from
Jun 22, 2026
Merged

Fix Core/Downgrade SuperLUDIST resolve skip and StaticArrays.LU init_cacheval regression #1053

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4c8f89
Skip SuperLUDISTFactorization in Core resolve test
ChrisRackauckas Jun 20, 2026
077af4a
Fix StaticArrays.LU `.factors` access in GenericLU/RFLU init_cacheval
ChrisRackauckas Jun 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/factorization.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,8 @@ function init_cacheval(
assumptions::OperatorAssumptions
)
ipiv = Vector{LinearAlgebra.BlasInt}(undef, min(size(A)...))
# `solve!` stores `(generic_lufact!(A, ...), ipiv)` where the pivot is this
# `solve!` stores `(generic_lufact!(A, ...), ipiv)`, a `LinearAlgebra.LU` whose
# `factors` is `convert(AbstractMatrix, A)` and whose pivot is this
# `Vector{BlasInt}`. `lu_instance` would type the pivot after `A`'s container
# (e.g. a `FixedSizeVector` for a `FixedSizeArray`), so rebuild the instance
# with the `Vector` pivot to keep the cacheval slot type matching.
Expand Down
1 change: 1 addition & 0 deletions test/Core/resolve.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ for alg in vcat(
BLISLUFactorization,
AMDGPUOffloadLUFactorization,
AMDGPUOffloadQRFactorization,
SuperLUDISTFactorization,
]
) &&
(
Expand Down
Loading