Skip to content

QA: run_qa v1.6 form + ExplicitImports #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisRackauckas merged 2 commits into from
Jul 2, 2026
Merged

QA: run_qa v1.6 form + ExplicitImports #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e09dd5c
QA: run_qa v1.6 form + ExplicitImports
ChrisRackauckas Jun 25, 2026
b2182a6
QA: drop redundant public-API ExplicitImports ignores (SciMLTesting 1.7)
ChrisRackauckas Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ meshgeometry.geo
meshgeometry.msh
dev/Manifest.toml
test/Manifest.toml
test/qa/Manifest.toml
docs/build/
docs/site/
docs/Manifest.toml
Expand Down
6 changes: 2 additions & 4 deletions test/qa/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
[deps]
Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
ExplicitImports = "7d51a73a-1435-4ff3-83d9-f097790105c7"
FiniteVolumeMethod = "d4f04ab7-4f65-4d72-8a28-7087bc7f46f4"
SafeTestsets = "1bc83da4-3b8d-516f-aca4-4fe02f6d838f"
SciMLTesting = "09d9d899-5365-40a9-917a-5f67fddea283"
Expand All @@ -10,9 +9,8 @@ Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
FiniteVolumeMethod = {path = "../.."}

[compat]
Aqua = "0.7, 0.8"
ExplicitImports = "1.15.0"
Aqua = "0.8"
SafeTestsets = "0.1, 1"
SciMLTesting = "1"
SciMLTesting = "1.6"
Test = "1"
julia = "1.10"
22 changes: 9 additions & 13 deletions test/qa/qa.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,10 @@
using FiniteVolumeMethod
using Test
using Aqua
using ExplicitImports
using SciMLTesting, FiniteVolumeMethod, Test

@testset verbose = true "Aqua" begin
Aqua.test_all(FiniteVolumeMethod; ambiguities = false, project_extras = false) # don't care about julia < 1.2
Aqua.test_ambiguities(FiniteVolumeMethod) # don't pick up Base and Core...
end

@testset verbose = true "Explicit Imports" begin
@test check_no_implicit_imports(FiniteVolumeMethod) === nothing
@test check_no_stale_explicit_imports(FiniteVolumeMethod) === nothing
end
run_qa(
FiniteVolumeMethod;
explicit_imports = true,
# Root Project.toml carries only `Test` in [extras]/[targets]; the real test
# deps live in test/Project.toml under the grouped-tests folder model, so the
# root-vs-test consistency check does not apply here.
aqua_kwargs = (; project_extras = false),
)
Loading