Skip to content

QA: run_qa v1.6 form + ExplicitImports #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisRackauckas merged 1 commit into from
Jun 27, 2026
Merged

QA: run_qa v1.6 form + ExplicitImports #157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ SpecialFunctions = "276daf66-3868-5448-9aa4-cd146d93841b"

[compat]
ADTypes = "1"
ExplicitImports = "1"
LinearAlgebra = "1"
OrdinaryDiffEq = "6, 7"
OrdinaryDiffEqSDIRK = "1, 2"
Expand All @@ -24,12 +23,11 @@ julia = "1.10"

[extras]
ADTypes = "47edcb42-4c32-4615-8424-f2b9edc5f35b"
ExplicitImports = "7d51a73a-1435-4ff3-83d9-f097790105c7"
OrdinaryDiffEq = "1dea7af3-3e70-54e6-95c3-0bf5283fa5ed"
OrdinaryDiffEqSDIRK = "2d112036-d095-4a1e-ab9a-08536f3ecdbf"
SafeTestsets = "1bc83da4-3b8d-516f-aca4-4fe02f6d838f"
SciMLTesting = "09d9d899-5365-40a9-917a-5f67fddea283"
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"

[targets]
test = ["ADTypes", "ExplicitImports", "Test", "OrdinaryDiffEq", "OrdinaryDiffEqSDIRK", "SafeTestsets", "SciMLTesting"]
test = ["ADTypes", "Test", "OrdinaryDiffEq", "OrdinaryDiffEqSDIRK", "SafeTestsets", "SciMLTesting"]
4 changes: 0 additions & 4 deletions test/core.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,6 @@ using Test

FEniCS.set_log_level(FEniCS.WARNING)

@testset "Explicit Imports" begin
include("explicit_imports.jl")
end

examples_dir = joinpath(@__DIR__, "..", "examples")
@assert ispath(examples_dir)
example_filenames = readdir(examples_dir)
Expand Down
8 changes: 0 additions & 8 deletions test/explicit_imports.jl
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion test/qa/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,6 @@ FEniCS = {path = "../.."}
Aqua = "0.8"
JET = "0.9,0.10,0.11"
SafeTestsets = "0.1, 1"
SciMLTesting = "1"
SciMLTesting = "1.6"
Test = "1"
julia = "1.10"
21 changes: 13 additions & 8 deletions test/qa/qa.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,14 @@
using FEniCS, Aqua, JET, Test
using SciMLTesting, FEniCS, Test
using JET

@testset "Aqua" begin
Aqua.test_all(FEniCS)
end

@testset "JET" begin
JET.test_package(FEniCS; target_defined_modules = true)
end
run_qa(
FEniCS;
explicit_imports = true,
ei_kwargs = (;
# `getdoc` is not public in `Base.Docs`, but FEniCS extends
# `Base.Docs.getdoc(::fenicsobject)` (src/FEniCS.jl) to surface the wrapped
# PyObject's docstring. Extending a Base-internal method legitimately
# requires naming it; nothing to make public here.
all_qualified_accesses_are_public = (; ignore = (:getdoc,)),
),
)
Loading