Use SciMLTesting v1.2 (folder-based run_tests)#115
Merged
ChrisRackauckas merged 1 commit intoJun 14, 2026
Conversation
166927e to
b02342f
Compare
Replace the hand-written GROUP dispatch in test/runtests.jl with the folder-discovery `run_tests()` from SciMLTesting v1.2. Core stays at the top level (basic, more_generic, cartesian, alloc_tests); QA moves into test/qa/ (qa.jl + explicit_imports.jl joined the existing jet.jl) so the top-level Core glob does not pick them up. The qa sub-env activation is now owned by the harness. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
b02342f to
b04f1bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts EllipsisNotation.jl to the SciMLTesting v1.2 folder-discovery model.
test/runtests.jlis now just:Layout:
test/*.jl—basic.jl,more_generic.jl,cartesian.jl,alloc_tests.jl.test/qa/):qa.jlandexplicit_imports.jlmoved intotest/qa/to join the existingjet.jl, so the Core top-level glob does not erroneously pick them up. Thetest/qa/Project.tomlsub-env (Aqua/ExplicitImports/JET) activation is now owned by the harness.test/test_groups.tomlis unchanged. Deps: addedSciMLTesting(compat1) to the root[extras]/[targets].test/[compat]and totest/qa/Project.toml(plusSafeTestsetsthere); droppedPkgfrom the root test deps (notest/*.jluses it — the v1.2 harness owns all Pkg ops).Verified end-to-end on Julia 1.11 with SciMLTesting v1.2.0:
GROUP=Core(alloc 4/4, basic 27/27, cartesian 6/6, more_generic 5/5) andGROUP=QA(explicit_imports 2/2, jet 14/14, qa 10/10) both pass. The per-GROUP test set matches the previous dispatch (CI runs Core and QA as separate lanes via the centralized grouped-tests workflow).Ignore until reviewed by @ChrisRackauckas.