QA: restore Aqua deps_compat (add missing [compat] for test extras)#114
Merged
ChrisRackauckas merged 1 commit intoJun 13, 2026
Merged
Conversation
The grouped-tests CI conversion added `Pkg` to [extras]/[targets].test without a corresponding [compat] entry, which trips Aqua's test_deps_compat extras sub-check. Instead of weakening the check (check_extras=false + a @test_broken false sentinel), add the missing `Pkg = "1"` compat bound and restore the full `Aqua.test_deps_compat(EllipsisNotation)` call. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Note: this PR was opened with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The grouped-tests CI conversion added
Pkgto[extras]/[targets].testin the packageProject.tomlwithout a corresponding[compat]entry. This trips Aqua'stest_deps_compatextras sub-check.The conversion worked around this by weakening the check rather than fixing the metadata:
Aqua.test_deps_compat(EllipsisNotation, check_extras = false)plus a@test_broken falsesentinel, with a tracking issue (#113).Fix (metadata only, one-line)
Pkg = "1"to[compat]in the rootProject.toml.Aqua.test_deps_compat(EllipsisNotation)call intest/qa.jland remove thecheck_extras = falseweakening +@test_broken falsesentinel.This is CI-hygiene (metadata + re-enabling a check), not a test-logic change.
Local verification
GROUP=QA julia +1.11 ... Pkg.test()passes:Closes #113 (that issue covered only this deps_compat nit).
Ignore until reviewed by @ChrisRackauckas.