Skip to content

QA: restore Aqua deps_compat (add missing [compat] for test extras)#114

Merged
ChrisRackauckas merged 1 commit into
SciML:masterfrom
ChrisRackauckas-Claude:fix-aqua-deps-compat
Jun 13, 2026
Merged

QA: restore Aqua deps_compat (add missing [compat] for test extras)#114
ChrisRackauckas merged 1 commit into
SciML:masterfrom
ChrisRackauckas-Claude:fix-aqua-deps-compat

Conversation

@ChrisRackauckas-Claude

Copy link
Copy Markdown
Contributor

Problem

The grouped-tests CI conversion added Pkg to [extras]/[targets].test in the package Project.toml without a corresponding [compat] entry. This trips Aqua's test_deps_compat extras sub-check.

The conversion worked around this by weakening the check rather than fixing the metadata: Aqua.test_deps_compat(EllipsisNotation, check_extras = false) plus a @test_broken false sentinel, with a tracking issue (#113).

Fix (metadata only, one-line)

  1. Add the missing Pkg = "1" to [compat] in the root Project.toml.
  2. Restore the full Aqua.test_deps_compat(EllipsisNotation) call in test/qa.jl and remove the check_extras = false weakening + @test_broken false sentinel.

This is CI-hygiene (metadata + re-enabling a check), not a test-logic change.

Local verification

GROUP=QA julia +1.11 ... Pkg.test() passes:

Quality Assurance |   10     10  27.3s
Explicit Imports  |    2      2
JET               |   14     14
Testing EllipsisNotation tests passed

Closes #113 (that issue covered only this deps_compat nit).

Ignore until reviewed by @ChrisRackauckas.

The grouped-tests CI conversion added `Pkg` to [extras]/[targets].test
without a corresponding [compat] entry, which trips Aqua's
test_deps_compat extras sub-check. Instead of weakening the check
(check_extras=false + a @test_broken false sentinel), add the missing
`Pkg = "1"` compat bound and restore the full
`Aqua.test_deps_compat(EllipsisNotation)` call.

Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@ChrisRackauckas ChrisRackauckas marked this pull request as ready for review June 13, 2026 09:15
@ChrisRackauckas ChrisRackauckas merged commit d1d05ea into SciML:master Jun 13, 2026
5 of 6 checks passed
@ChrisRackauckas-Claude

Copy link
Copy Markdown
Contributor Author

Note: this PR was opened with --draft but the account lacks permission to set/keep the draft flag on this repo, so it shows as ready. It is not ready for merge — please treat it as a draft. Ignore until reviewed by @ChrisRackauckas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

QA: Aqua/JET findings marked @test_broken pending fix

2 participants