Canonical CI: grouped-tests.yml + root test/test_groups.toml#112
Merged
ChrisRackauckas merged 3 commits intoJun 10, 2026
Merged
Conversation
Convert the root test workflow to the canonical SciML grouped-tests.yml@v1 thin caller, with the version/OS/group matrix declared once in test/test_groups.toml. - Tests.yml becomes a thin caller (on:/concurrency: preserved verbatim). - test/test_groups.toml: Core on [lts,1,pre] x [ubuntu,windows,macos]; QA on [lts,1]. - Aqua + ExplicitImports (previously inline in Core) and JET (previously a standalone JET.yml workflow) are consolidated into a QA group, isolated in test/qa/Project.toml (Aqua/ExplicitImports/JET/Test + the package via [sources]). runtests.jl activates + develops + instantiates that env when GROUP==QA. JET.yml and test/jet/ removed. - Core keeps the functional + allocation tests (basic, more_generic, cartesian, alloc_tests). - Project.toml: QA-only deps (Aqua, ExplicitImports) dropped from the main [extras]/[targets] now that they live in test/qa. julia compat stays at the 1.10 LTS floor; all remaining [extras] entries have [compat] bounds. No tests/Aqua/JET were run locally; this is a structural conversion. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The Core test group runs with project='.', and test/runtests.jl does `using Pkg` to activate the QA sub-environment. Pkg was not a declared test dependency in the root test env, so the Core job failed with `ArgumentError: Package Pkg not found in current path`. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…mpat) The QA group's Aqua test_deps_compat extras check fails because Pkg is listed in [extras]/[targets].test without a [compat] entry. Keep the deps and weakdeps sub-checks running (check_extras=false) and mark the extras finding @test_broken so the QA group is green. Tracked in SciML#113. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Converts the root test workflow to the canonical SciML
grouped-tests.yml@v1thin caller, with the test matrix declared once intest/test_groups.toml.Tests.ymlbecomes a thin caller ofSciML/.github/.github/workflows/grouped-tests.yml@v1(secrets: inherit, all-defaultwith:). Theon:andconcurrency:blocks are preserved verbatim.test/test_groups.tomldeclares the matrix:Coreon[lts, 1, pre]×[ubuntu-latest, windows-latest, macos-latest]QAon[lts, 1](ubuntu)JET.ymlworkflow with its owntest/jet/project. These are consolidated into a single QA group, isolated intest/qa/Project.toml(Aqua / ExplicitImports / JET / Test + the package via[sources]).runtests.jlactivates + develops + instantiates that env whenGROUP=="QA", then runsqa.jl(Aqua),explicit_imports.jl, andqa/jet.jl.JET.ymlandtest/jet/are removed.basic,more_generic,cartesian,alloc_tests).Project.toml— QA-only deps (Aqua, ExplicitImports) dropped from the main[extras]/[targets]now that they live intest/qa. Thejuliacompat stays at the1.10LTS floor; all remaining[extras]entries carry[compat]bounds.Matrix match
The emitted root matrix reproduces the OLD workflows exactly:
Tests.yml: [1,lts,pre] × [ubuntu,macos,windows])JET.yml: [1,lts] ubuntu; Aqua/ExplicitImports were inline in Core)Verified statically with
compute_affected_sublibraries.jl --root-matrix(11 cells: 9 Core + 2 QA). TOML and YAML parse confirmed. No tests / Aqua / JET were run locally — this is a structural conversion.The QA group is newly wired; Aqua/JET run in CI — any failures will be triaged in a follow-up.
Ignore until reviewed by @ChrisRackauckas.
🤖 Generated with Claude Code