Skip to content

QA: run_qa v1.6 form + ExplicitImports #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisRackauckas merged 1 commit into from
Jun 25, 2026
Merged

QA: run_qa v1.6 form + ExplicitImports #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,23 +8,23 @@ LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
RecipesBase = "3cdcf5f2-1ef4-517c-9805-6587b60abb01"

[compat]
ExplicitImports = "1"
Aqua = "0.8"
JET = "0.9,0.10,0.11"
LinearAlgebra = "1"
Plots = "1"
RecipesBase = "1.0"
SafeTestsets = "0.1, 1"
SciMLTesting = "1"
SciMLTesting = "1.6"
Test = "1"
julia = "1.10"

[extras]
Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
ExplicitImports = "7d51a73a-1435-4ff3-83d9-f097790105c7"
JET = "c3a54625-cd67-489e-a8e7-0a5a0ff4e31b"
Plots = "91a5bcdd-55d7-5caf-9e0b-520d859cae80"
SafeTestsets = "1bc83da4-3b8d-516f-aca4-4fe02f6d838f"
SciMLTesting = "09d9d899-5365-40a9-917a-5f67fddea283"
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"

[targets]
test = ["Aqua", "ExplicitImports", "JET", "Plots", "SafeTestsets", "SciMLTesting", "Test"]
test = ["Aqua", "JET", "Plots", "SafeTestsets", "SciMLTesting", "Test"]
8 changes: 0 additions & 8 deletions test/explicit_imports.jl
View file
Open in desktop

This file was deleted.

4 changes: 3 additions & 1 deletion test/qa/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
DimensionalPlotRecipes = "c619ae07-58cd-5f6d-b883-8f17bd6a98f9"
JET = "c3a54625-cd67-489e-a8e7-0a5a0ff4e31b"
RecipesBase = "3cdcf5f2-1ef4-517c-9805-6587b60abb01"
SafeTestsets = "1bc83da4-3b8d-516f-aca4-4fe02f6d838f"
SciMLTesting = "09d9d899-5365-40a9-917a-5f67fddea283"
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
Expand All @@ -12,7 +13,8 @@ DimensionalPlotRecipes = {path = "../.."}
[compat]
Aqua = "0.8"
JET = "0.9,0.10,0.11"
RecipesBase = "1"
SafeTestsets = "0.1, 1"
SciMLTesting = "1"
SciMLTesting = "1.6"
Test = "1"
julia = "1.10"
21 changes: 9 additions & 12 deletions test/qa/qa.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,10 @@
using DimensionalPlotRecipes, Aqua, JET, Test
using SciMLTesting, DimensionalPlotRecipes, JET, Test
using RecipesBase: apply_recipe

@testset "Aqua" begin
# deps_compat and piracies are genuine findings tracked in
# https://github.com/SciML/DimensionalPlotRecipes.jl/issues/50
Aqua.test_all(DimensionalPlotRecipes; deps_compat = false, piracies = false)
@test_broken false # Aqua deps_compat: root Project.toml lacks compat for Aqua/JET extras — see https://github.com/SciML/DimensionalPlotRecipes.jl/issues/50
@test_broken false # Aqua piracies: @recipe-generated apply_recipe on RecipesBase types — see https://github.com/SciML/DimensionalPlotRecipes.jl/issues/50
end

@testset "JET" begin
@test_broken false # JET: no matching method `is_key_supported(::Symbol)` in apply_recipe — see https://github.com/SciML/DimensionalPlotRecipes.jl/issues/50
end
# The @recipe-generated method defines RecipesBase.apply_recipe but is owned by
# DimensionalPlotRecipes, so Aqua flags it as piracy; treat_as_own clears it.
run_qa(
DimensionalPlotRecipes;
explicit_imports = true,
aqua_kwargs = (; piracies = (; treat_as_own = [apply_recipe])),
)
Loading