Fix SciMLBase v3 breaking changes and bump version#288
Closed
ChrisRackauckas wants to merge 1 commit into
Closed
Conversation
- Replace removed DiffEqBase.DEProblem with DiffEqBase.AbstractDEProblem in two_stage_objective and multiple_shooting_objective signatures - Fix length(sol) -> length(sol.t) in L2Loss AbstractSciMLSolution dispatch (v3 length(sol) returns nstates*ntimesteps, not just ntimesteps) - Fix sol[k][1]/sol[k-1][end] -> sol[k].u[1]/sol[k-1].u[end] in multiple_shooting_objective discontinuity penalty (v3 scalar indexing) - Update SciMLBase compat from "1.69, 2" to "2, 3" - Bump package version from 2.3.0 to 2.4.0 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DiffEqBase.DEProblemwithDiffEqBase.AbstractDEProblemintwo_stage_objectiveandmultiple_shooting_objectivesignatureslength(sol)→length(sol.t)inL2LossAbstractSciMLSolutiondispatch (in SciMLBase v3,length(sol)returnsnstates * ntimestepsrather than justntimesteps)sol[k][1]→sol[k].u[1]andsol[k-1][end]→sol[k-1].u[end]inmultiple_shooting_objectivediscontinuity penalty (in v3, scalar indexing on anODESolutiongives the first element across all components, not the first timestep state vector)"1.69, 2"→"2, 3"(dropping v1 since the fixes are not backward compatible with v1 behavior)🤖 Generated with Claude Code