Skip to content

Fix Aqua QA failures: unbound type parameters in validate_cache and missing Pkg compat #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisRackauckas merged 2 commits into from
Jun 10, 2026
Merged

Fix Aqua QA failures: unbound type parameters in validate_cache and missing Pkg compat #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
acf5dfe
Fix Aqua QA failures: unbound type parameters and missing Pkg compat
ChrisRackauckas Jun 10, 2026
22b6e9b
Merge branch 'main' into fix-qa-aqua-failures
ChrisRackauckas Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ DataInterpolations = "8"
EllipsisNotation = "1.8.0"
ForwardDiff = "0"
KernelAbstractions = "0.9.34"
Pkg = "1"
PrecompileTools = "1.2.1"
Random = "1"
RecipesBase = "1.3.4"
Expand Down
12 changes: 3 additions & 9 deletions src/interpolation_utils.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,7 @@ function validate_size_u(
return @assert expected_size == size(u)[1:N_in] "Expected the size of the first N_in dimensions of u to be $expected_size based on the BSplineInterpolation properties."
end

function validate_cache(
::EmptyCache, ::NTuple{N_in, ID}, ::AbstractArray
) where {N_in, ID}
return nothing
end
validate_cache(::EmptyCache, ::Tuple, ::AbstractArray) = nothing

function validate_cache(
nurbs_weights::NURBSWeights,
Expand All @@ -66,10 +62,8 @@ function validate_cache(
return @assert size(nurbs_weights.weights) == size_expected "The size of the weights array must match the length of the first N_in dimensions of u ($size_expected)."
end

function validate_cache(
::gType, ::NTuple{N_in, ID}, ::AbstractArray
) where {gType, N_in, ID}
return @error("Interpolation dimension type $ID is not compatible with global cache type $gType.")
function validate_cache(cache, interp_dims::Tuple, ::AbstractArray)
return @error("Interpolation dimension type $(eltype(interp_dims)) is not compatible with global cache type $(typeof(cache)).")
end

function get_ts(
Expand Down
Loading