-
-
Notifications
You must be signed in to change notification settings - Fork 8
Generalise _interpolate! to allow mixed dimensions
#33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rafaqz
wants to merge
33
commits into
SciML:main
Choose a base branch
from
rafaqz:generalis_interpolate
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
d37c715
gneralise interpolate to allow mixed dimensions
rafaqz b36c2d9
cleanup
rafaqz ad6bdaa
simpler type, single _interpolat! method
rafaqz 3b6aa64
bugfix
rafaqz 2e8b635
handle empty dimensions with NoInterpolationDimension
rafaqz c4595d2
more fixes for mixed dimensions
rafaqz b384f41
more mixed dims
rafaqz d6d652d
cleanup
rafaqz 87dd1ab
tweaks
rafaqz 107dd45
working besides Constant nans
rafaqz 9061c83
fix ConstantInterpolationDimension nans
rafaqz 0bfe73c
remove constant
rafaqz 42e6d68
fix eval grid checks
rafaqz 60c36a2
simplify and minimise changes
rafaqz cb2864d
rename scale to weight
rafaqz c010f30
cleanup grid_size
rafaqz 5a87b17
explicity multi_point_index
rafaqz 31fe7ea
bugfix and test nointerp itp()
rafaqz 471b1e5
cleanup
rafaqz 09e20e2
run JuliaFormatter
rafaqz 05f2c4c
use JuliaFormatter v2
rafaqz a27ae40
bugfix eval_unstructured
rafaqz 0222ba0
review suggestions
rafaqz 00704e4
use NURBS
rafaqz b37af8c
dim checks
rafaqz 45fbe9b
bugfix constructor changes
rafaqz 3537e53
comments and format
rafaqz 79acff4
fix NoInterpolationDimension docstring
rafaqz 14263fd
Merge remote-tracking branch 'upstream/main' into generalis_interpolate
SouthEndMusic 9d87744
Fixes
SouthEndMusic f7e25bd
Mix interpolation types in examples
SouthEndMusic 1d07fce
Update NDInterpolation docstring
SouthEndMusic a10aabf
Remove redundant comment
SouthEndMusic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I vaguely remember the discussion on this. I think avoiding the breaking change would be nicest. When indexing for the
NoInterpolationDimensionwe should support integers and slices. We could overloadgetindexfor this, or is that too much outside the scope of that pattern/syntax?