Bump StaticArrays compat floor to 1.9.8 (fixes Julia 1.10 Downgrade precompile)#553
Merged
Merged
Conversation
… Julia 1.10) StaticArrays 1.9.7 fails to precompile on Julia 1.10 with `UndefVarError: require_one_based_indexing not defined`, which breaks the Downgrade CI lane (it resolves to the minimal compatible version). 1.9.8 is the first patch that precompiles cleanly on 1.10. Bump the floor from 1.9.7 to 1.9.8 in the root Project.toml and test/qa/Project.toml for consistency. Compat-only change (no public API touched), so this is a patch release. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Downgrade CI lane fails because it resolves
StaticArraysto the compat floor1.9.7, and StaticArrays 1.9.7 fails to precompile on Julia 1.10 with:1.9.8is the first patch release that precompiles cleanly on 1.10.Fix
Compat-only floor bump
1.9.7 -> 1.9.8in:Project.toml(root)test/qa/Project.tomltest/Extensions/Project.tomldoes not pin StaticArrays, so no change there.No source or public-API change, so this is a patch release.
Validation (local, Julia 1.10.11)
StaticArrays 1.9.7precompile fails on 1.10.11 withrequire_one_based_indexingUndefVarError;1.9.8precompiles cleanly.--min=@deps) on both Julia 1.10 and Julia 1.12 with the new floor: resolves successfully, manifest pinsStaticArrays = 1.9.8.DataInterpolationsprecompiles successfully and a BSpline interpolation evaluates correctly (the path that previously died during precompile).Note on the QA (julia 1) lane
The separate QA
@check_allocsfailure on the BSpline path is a Julia-1.12-runner-specific AllocCheck false positive (0 allocations locally on the exact env; Core/Methods green on 1.12). It is not a code regression and is intentionally not addressed here (no test loosening, no@test_broken) — it needs an infra/upstream decision rather than a source change. This PR is scoped only to the genuine Downgrade floor fix.🤖 Generated with Claude Code