Skip to content

QA: run_qa v1.6 form + ExplicitImports #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisRackauckas merged 3 commits into from
Jun 27, 2026
+23 −16
Merged

QA: run_qa v1.6 form + ExplicitImports #549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d6f4710
QA: run_qa v1.6 form + ExplicitImports
ChrisRackauckas Jun 25, 2026
53204dc
QA: sweep redundant public-API EI ignores after SciMLTesting 1.7
ChrisRackauckas Jun 26, 2026
e1ac0e3
QA: bump SciMLTesting floor to 1.7 and drop inert require_one_based_i…
ChrisRackauckas Jun 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/DataInterpolations.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,11 @@ module DataInterpolations

abstract type AbstractInterpolation{T} end

using LinearAlgebra, RecipesBase
using PrettyTables
using ForwardDiff
using EnumX
using LinearAlgebra: LinearAlgebra, Tridiagonal, dot, norm, normalize!
using RecipesBase: RecipesBase, @recipe, @series
using PrettyTables: PrettyTables, pretty_table
using ForwardDiff: ForwardDiff
using EnumX: EnumX, @enumx
import FindFirstFunctions
import FindFirstFunctions: Guesser

Expand Down
2 changes: 1 addition & 1 deletion test/qa/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@ DataInterpolations = {path = "../.."}
AllocCheck = "0.2"
Aqua = "0.8"
SafeTestsets = "0.0.1, 0.1"
SciMLTesting = "1"
SciMLTesting = "1.7"
StaticArrays = "1.9.7"
Test = "1"
28 changes: 17 additions & 11 deletions test/qa/qa.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,17 @@
using DataInterpolations, Aqua
@testset "Aqua" begin
Aqua.find_persistent_tasks_deps(DataInterpolations)
Aqua.test_ambiguities(DataInterpolations, recursive = false)
Aqua.test_deps_compat(DataInterpolations)
Aqua.test_piracies(DataInterpolations)
Aqua.test_project_extras(DataInterpolations)
Aqua.test_stale_deps(DataInterpolations)
Aqua.test_unbound_args(DataInterpolations)
Aqua.test_undefined_exports(DataInterpolations)
end
using SciMLTesting, DataInterpolations, Test

run_qa(
DataInterpolations;
explicit_imports = true,
ei_kwargs = (;
# `@enumx ExtrapolationType ...` generates a submodule with dynamic includes
# that ExplicitImports cannot statically analyze; allow it to be unanalyzable
# rather than failing the import-graph checks.
no_implicit_imports = (; allow_unanalyzable = (DataInterpolations.ExtrapolationType,)),
no_stale_explicit_imports = (; allow_unanalyzable = (DataInterpolations.ExtrapolationType,)),
# ForwardDiff.{Dual,derivative,value} are not marked public in ForwardDiff,
# so the public-API check flags them; keep them allowed until ForwardDiff
# declares them public.
all_qualified_accesses_are_public = (; ignore = (:Dual, :derivative, :value)),
),
)
Loading