QA: run_qa v1.6 form + ExplicitImports#31
Merged
ChrisRackauckas merged 1 commit intoJun 27, 2026
Conversation
Convert the hand-rolled JET-only test/qa/qa.jl to the SciMLTesting 1.6
run_qa form with ExplicitImports enabled (explicit_imports = true), so
the QA group runs the full standard body: Aqua.test_all (8 sub-checks),
JET.test_package, and the 6 ExplicitImports checks.
ExplicitImports findings resolved:
- no_implicit_imports: made LinearAlgebra usage explicit
(using LinearAlgebra: Diagonal, det, mul!) instead of bare using.
- all_explicit_imports_are_public: ignore fast_scalar_indexing
(not yet public in ArrayInterface) via ei_kwargs.
Aqua compat findings fixed in the root Project.toml:
- add LinearAlgebra compat (stdlib, "1").
- add JET compat for the test extra ("0.9, 0.10, 0.11").
Deps:
- test/qa/Project.toml keeps Aqua a direct dep (its ambiguities
sub-check spawns a child process that must import Aqua) and bumps the
SciMLTesting floor to 1.6; ExplicitImports stays transitive via
SciMLTesting.
- root SciMLTesting compat bumped to 1.6.
Verified locally against released SciMLTesting 1.6.0 (no dev-from-branch)
on the run_tests QA folder path: QA/qa.jl 18/18 pass on Julia 1.10 (lts),
1.11, and 1.12, 0 fail/error/broken.
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ignore until reviewed by @ChrisRackauckas.
Converts the hand-rolled JET-only
test/qa/qa.jlto the SciMLTesting 1.6run_qaform with ExplicitImports enabled (explicit_imports = true). The QA group now runs the full standard body:Aqua.test_all(8 sub-checks),JET.test_package, and the 6 ExplicitImports checks.ExplicitImports findings (all FIXED/IGNORED, 0 broken)
Diagonal,det,mul!). FIX: made explicit insrc/DataCollocations.jl—using LinearAlgebra: Diagonal, det, mul!replacing bareusing LinearAlgebra.fast_scalar_indexingis not (yet) public in ArrayInterface. IGNORE viaei_kwargs.all_explicit_imports_are_public = (; ignore = (:fast_scalar_indexing,))(other package's non-public name; will go public as ArrayInterface marks it).Aqua compat findings (FIXED in root Project.toml)
deps_compat:LinearAlgebra(stdlib dep) had no[compat]entry → addedLinearAlgebra = "1".deps_compatextras: theJETtest extra had no[compat]entry → addedJET = "0.9, 0.10, 0.11".Deps
test/qa/Project.toml: keep Aqua a direct dep — itsambiguitiessub-check spawns a child process thatimport Aqua, which fails ("Package Aqua not found in current path") when Aqua is only transitive. BumpedSciMLTestingfloor to1.6; ExplicitImports stays transitive via SciMLTesting (no direct dep).[compat]:SciMLTestingbumped1→1.6.Verified locally vs released SciMLTesting 1.6.0
No dev-from-branch — Pkg resolves SciMLTesting 1.6.0. Ran the QA group via the
run_testsfolder path (GROUP=QAPkg.test):0 fail / 0 error / 0 broken on Julia 1.10 (lts), 1.11, and 1.12 (JET 0.11 picked on 1.12). All intended checks run: 11 Aqua results +
JET.test_package+ 6 ExplicitImports.🤖 Generated with Claude Code