More stats fixes#115
Merged
Merged
Conversation
Otherwise the wrong problem with the wrong x/y/sigma/lb/ub/u0 will be used by the stats functions.
ChrisRackauckas
approved these changes
Jun 28, 2026
Member
|
Seems we need to mark public differently for this? |
Member
Author
|
Yeah, though I don't understand why |
- Added support for passing arrays to solutions of King, modified King, and rational polynomial fits. - Make `ExpSumFitAlgorithm` solutions return scalars for scalar inputs.
Member
Author
|
Ah it just needed to be excluded in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More things found by an audit with Codex:
withconst=trueis passed to an exp sum fit thekparameter is fixed, which was not handled correctly byvcov.dof()also incorrectly returned 3 instead of 2.reinit!(cache)for nonlinear fits,cache.probwasn't updated even though it was passed to the solution, which meant that anything usingsol.prob(i.e. all the stats functions) would give the results for the original problem.sol(x::AbstractArray)wasn't implemented for some algorithm types so this commit adds support for them. Also changes the implementation for exp sum fits such thatsol(x)for scalar inputs returns a scalar. This is technically a breaking change but I would consider it a bug fix since returning an array seems a bit weird for a scalar input.Written with help from Codex 🤖
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.