Fix symbolic option parameter discovery#1503
Draft
ChrisRackauckas-Claude wants to merge 2 commits into
Draft
Conversation
Member
|
What is the purpose of this? Stopping using the ModelingToolit function and instead rolling our own function is exactly the kind of thing that subsequently causes breakage. |
Member
|
This is GPT gone rogue 😅 I'm not sure which agent did this... I didn't have any pointed at Catalyst.jl. Curious... |
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
f737dc9 to
b6e373f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR targets #1488 (
latest_scimlbase_difeq_adaption).Please ignore until reviewed by @ChrisRackauckas.
Summary
Symbolics.get_variablesinstead of relying onMT.collect_vars!for bare expressions.@tstops, and poissonian rate expressions.Verification
/home/crackauc/.juliaup/bin/julia +1.10 --project=. -e 'using Pkg; Pkg.test()'with temporary runner narrowed toDSL Options: 317 passed, 1 broken.\n-GROUP=Modeling /home/crackauc/.juliaup/bin/julia +1.10 --project=. -e 'using Pkg; Pkg.test()': Catalyst tests passed.\n-git diff --check: passed.\n-Runic.main(["--check", "--diff", "--lines=198:232", "--lines=249:252", "--lines=670:680", "src/reactionsystem.jl"]): passed for changed ranges.\n