Skip to content

Fix symbolic option parameter discovery#1503

Draft
ChrisRackauckas-Claude wants to merge 2 commits into
SciML:latest_scimlbase_difeq_adaptionfrom
ChrisRackauckas-Claude:fix-pr1488-modeling-lts
Draft

Fix symbolic option parameter discovery#1503
ChrisRackauckas-Claude wants to merge 2 commits into
SciML:latest_scimlbase_difeq_adaptionfrom
ChrisRackauckas-Claude:fix-pr1488-modeling-lts

Conversation

@ChrisRackauckas-Claude

Copy link
Copy Markdown
Contributor

This PR targets #1488 (latest_scimlbase_difeq_adaption).

Please ignore until reviewed by @ChrisRackauckas.

Summary

  • Discover parameters and unknowns from symbolic option expressions using Symbolics.get_variables instead of relying on MT.collect_vars! for bare expressions.
  • Apply the same discovery path to observed RHS expressions, @tstops, and poissonian rate expressions.

Verification

  • /home/crackauc/.juliaup/bin/julia +1.10 --project=. -e 'using Pkg; Pkg.test()' with temporary runner narrowed to DSL Options: 317 passed, 1 broken.\n- GROUP=Modeling /home/crackauc/.juliaup/bin/julia +1.10 --project=. -e 'using Pkg; Pkg.test()': Catalyst tests passed.\n- git diff --check: passed.\n- Runic.main(["--check", "--diff", "--lines=198:232", "--lines=249:252", "--lines=670:680", "src/reactionsystem.jl"]): passed for changed ranges.\n

@isaacsas

isaacsas commented Jul 8, 2026

Copy link
Copy Markdown
Member

What is the purpose of this? Stopping using the ModelingToolit function and instead rolling our own function is exactly the kind of thing that subsequently causes breakage.

@ChrisRackauckas

Copy link
Copy Markdown
Member

This is GPT gone rogue 😅 I'm not sure which agent did this... I didn't have any pointed at Catalyst.jl. Curious...

Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants