Skip to content

Normalize nopre -> QA (+ split AD/Enzyme) #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisRackauckas merged 1 commit into from
Jun 15, 2026
Merged

Normalize nopre -> QA (+ split AD/Enzyme) #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 test/NoPre/Project.toml → test/qa/Project.toml
View file
Open in desktop
File renamed without changes.
0 test/NoPre/qa.jl → test/qa/qa.jl
View file
Open in desktop
File renamed without changes.
0 test/NoPre/test_jet.jl → test/qa/test_jet.jl
View file
Open in desktop
File renamed without changes.
20 changes: 10 additions & 10 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,18 +2,18 @@ using Pkg
using SafeTestsets
using SciMLTesting

# The NoPre group runs Aqua/JET in the test/NoPre sub-env, but only on a non-prerelease
# The QA group runs Aqua/JET in the test/QA sub-env, but only on a non-prerelease
# Julia: those tools produce spurious reports on prerelease builds, so the whole group
# (env activation included) is a no-op on a `pre` matrix entry. A folder-discovery body
# cannot express this guard, so NoPre stays an explicit thunk. "Quality" is a legacy
# alias for NoPre.
function nopre_group()
# cannot express this guard, so QA stays an explicit thunk. "Quality" is a legacy
# alias for QA.
function qa_group()
isempty(VERSION.prerelease) || return nothing
Pkg.activate(joinpath(@__DIR__, "NoPre"))
Pkg.activate(joinpath(@__DIR__, "qa"))
Pkg.develop(PackageSpec(path = dirname(@__DIR__)))
Pkg.instantiate()
@safetestset "Quality Assurance" include(joinpath(@__DIR__, "NoPre", "qa.jl"))
@safetestset "JET Static Analysis" include(joinpath(@__DIR__, "NoPre", "test_jet.jl"))
@safetestset "Quality Assurance" include(joinpath(@__DIR__, "qa", "qa.jl"))
@safetestset "JET Static Analysis" include(joinpath(@__DIR__, "qa", "test_jet.jl"))
return nothing
end

Expand All @@ -23,9 +23,9 @@ run_tests(;
@safetestset "ANTLR Parser Tests" include("test_antlr_parser.jl")
return @safetestset "Error Message Tests" include("test_error_messages.jl")
end,
groups = Dict("NoPre" => nopre_group),
umbrellas = Dict("Quality" => ["NoPre"]),
# Original runtests ran NoPre/Quality only for those explicit GROUPs, never under
groups = Dict("QA" => qa_group),
umbrellas = Dict("Quality" => ["QA"]),
# Original runtests ran QA/Quality only for those explicit GROUPs, never under
# "All"; curate "All" to Core only to preserve that.
all = ["Core"],
)
4 changes: 2 additions & 2 deletions test/test_groups.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[Core]
versions = ["lts", "1", "pre"]

[NoPre]
versions = ["lts", "1", "pre"]
[QA]
versions = ["lts", "1"]
Loading