Skip to content

Migrate Downgrade.yml to SciML/.github central caller#128

Merged
ChrisRackauckas merged 1 commit into
SciML:mainfrom
ChrisRackauckas-Claude:downgrade-reenable
Jun 6, 2026
Merged

Migrate Downgrade.yml to SciML/.github central caller#128
ChrisRackauckas merged 1 commit into
SciML:mainfrom
ChrisRackauckas-Claude:downgrade-reenable

Conversation

@ChrisRackauckas-Claude

Copy link
Copy Markdown
Contributor

Summary

Migrates the bespoke Downgrade.yml (raw julia-actions/julia-downgrade-compat@v2 job) to the centralized reusable caller SciML/.github/.github/workflows/downgrade.yml@v1, matching the pattern already used by Tests.yml in this repo and by ~119 other SciML repos.

What changed

  • uses: SciML/.github/.github/workflows/downgrade.yml@v1 with secrets: inherit.
  • group: Core preserved (sole matrix entry).
  • julia-version: "1.10" preserved (LTS; Julia 1.10 support stays required).
  • allow-reresolve: false — strict, matches the prior ALLOW_RERESOLVE: false.
  • mode defaults to deps. The prior workflow declared a downgrade_mode: ['alldeps'] matrix variable but never referenced it in the julia-downgrade-compat@v2 step (the step only set skip: Pkg,TOML), so its effective mode was already deps. The central caller's default deps reproduces that exactly.
  • skip defaults to Pkg,TOML (matches prior).
  • pull_request/push triggers on main with paths-ignore: docs/** preserved.

Local verification (Julia 1.10, isolated depot)

Reproduced CI's strict downgrade exactly: pinned only the direct [deps] [compat] entries to their floors (CondaPkg=0.2.33, DiffEqBase=7.5, MLStyle=0.4.17, ModelingToolkit=11.24.0, ModelingToolkitBase=1.34.0, ParserCombinator=2, PythonCall=0.9.29), left [extras] test deps unpinned, then ran Pkg.test(; allow_reresolve=false) with GROUP=Core.

Test Summary: | Pass  Total     Time
BaseModelica  |  238    238  2m57.5s
     Testing BaseModelica tests passed

Resolution succeeded and 238/238 tests passed at the existing floors — no [compat] floor bumps were required, so this PR touches only Downgrade.yml.

Ignore until reviewed by @ChrisRackauckas.

🤖 Generated with Claude Code

Replace the bespoke raw julia-actions/julia-downgrade-compat@v2 workflow
with the centralized reusable caller
SciML/.github/.github/workflows/downgrade.yml@v1.

- group: Core (preserved)
- julia-version: "1.10" (LTS, preserved)
- allow-reresolve: false (strict, matches the prior ALLOW_RERESOLVE: false)
- mode defaults to deps (the prior alldeps matrix entry was never wired
  into the action step, so the effective mode was already deps)
- skip defaults to Pkg,TOML (matches the prior skip)
- secrets: inherit
- pull_request/push triggers on main with paths-ignore docs/** preserved

Downgrade suite run locally at the existing [compat] floors
(deps-mode, Pkg.test(allow_reresolve=false), Julia 1.10): PASS
(BaseModelica 238/238). No floor bumps were required.

Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@ChrisRackauckas ChrisRackauckas marked this pull request as ready for review June 6, 2026 23:22
@ChrisRackauckas ChrisRackauckas merged commit 9ab966c into SciML:main Jun 6, 2026
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants