ci(downgrade): default mode to "deps" (fix empty-mode regression)#68
Merged
ChrisRackauckas merged 1 commit intoJun 6, 2026
Merged
Conversation
PR SciML#64 added a `mode` input defaulting to "" and passed it through verbatim as `mode: "${{ inputs.mode }}"`. julia-downgrade-compat rejects an empty mode (`mode in valid_modes || error()`, downgrade.jl), so every downgrade.yml@v1 caller that does not set `mode` explicitly errors at the downgrade-compat step before tests run — breaking downgrade CI org-wide. PR SciML#67 added the `project` input but did NOT include this fix, so the regression is still live on @v1. Default `mode` to "deps" and map an explicit empty string to "deps" as well. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The empty-
moderegression from #64 is still live on@v1: the merged #67 added only theprojectinput, not themodefix.downgrade.ymlstill hasmodedefault""and passesmode: "${{ inputs.mode }}", whichjulia-downgrade-compatrejects (mode in valid_modes || error()), so every caller without an explicitmodefails at the downgrade-compat step before tests run.This sets the default to
depsand maps an explicit empty string todeps.After merge,
v1must be retagged for callers to pick it up. Until then, callers can work around it by passingmode: "deps"explicitly.🤖 Generated with Claude Code