Skip to content

ci: remove sublibrary-tests.yml (GROUP-dispatch) — project model is the single path#65

Merged
ChrisRackauckas merged 1 commit into
SciML:masterfrom
ChrisRackauckas-Claude:remove-sublibrary-tests
Jun 5, 2026
Merged

ci: remove sublibrary-tests.yml (GROUP-dispatch) — project model is the single path#65
ChrisRackauckas merged 1 commit into
SciML:masterfrom
ChrisRackauckas-Claude:remove-sublibrary-tests

Conversation

@ChrisRackauckas-Claude

@ChrisRackauckas-Claude ChrisRackauckas-Claude commented Jun 5, 2026

Copy link
Copy Markdown

Retires the GROUP-dispatch sublibrary-tests.yml so there's one sublibrary CI workflow: the project-model sublibrary-project-tests.yml (the OrdinaryDiffEq setup, which uses --projects-matrix).

  • Delete .github/workflows/sublibrary-tests.yml.
  • Drop the now-dead build_matrix / print_json from compute_affected_sublibraries.jl (the bare … <repo> group-matrix mode only sublibrary-tests.yml used). Kept: build_projects_matrix (--projects-matrix, the ODE/project-model path), --projects, and the shared json_value/EXCLUDES. No-flag invocation now errors. 37/37 script tests still pass.
  • README: collapse the "two execution models" comparison to the one model; remove the sublibrary-tests.yml section + its detection-script output row.

⚠️ Sequencing: 7 monorepos still reference sublibrary-tests.yml@v1 on their default branches (OrdinaryDiffEq, ModelingToolkit, Optimization, NonlinearSolve, DiffEqProblemLibrary, BoundaryValueDiffEq, Corleone) via open migration PRs. @v1 resolves to v1.3.0 which still has these, so merging now is safe — but the next v1 retag drops them, so those 7 PRs must merge before the next release. Tracked in #56.

Ignore until reviewed by @ChrisRackauckas.

🤖 Generated with Claude Code

…e one path

Retire the GROUP-dispatch sublibrary workflow in favor of the single
project-model sublibrary-project-tests.yml. Drop the README's "two execution
models" comparison down to the one model and remove the sublibrary-tests.yml
reference section + its detection-script output row.

NOTE: 7 monorepos still reference sublibrary-tests.yml@v1 on their default
branches (OrdinaryDiffEq, ModelingToolkit, Optimization, NonlinearSolve,
DiffEqProblemLibrary, BoundaryValueDiffEq, Corleone) via open migration PRs.
@v1 still resolves to v1.3.0 (which keeps the file), so this delete is safe
until the next v1 retag -- those migration PRs must merge before the next
release moves v1, or their SublibraryCI breaks.

Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@ChrisRackauckas ChrisRackauckas marked this pull request as ready for review June 5, 2026 09:53
@ChrisRackauckas ChrisRackauckas merged commit 577b30a into SciML:master Jun 5, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants