Skip to content

activity embedding (android 12L)#179

Open
Sinofine wants to merge 1 commit into
SchildiChat:scfrom
Sinofine:tablet-layout-multi-activity
Open

activity embedding (android 12L)#179
Sinofine wants to merge 1 commit into
SchildiChat:scfrom
Sinofine:tablet-layout-multi-activity

Conversation

@Sinofine

@Sinofine Sinofine commented Feb 25, 2023

Copy link
Copy Markdown
pj.mp4

mobile view (it doesnot affect small screens)

ww.mp4

@Sinofine Sinofine force-pushed the tablet-layout-multi-activity branch from 1a2c172 to 6f03ef6 Compare February 25, 2023 14:08
@Sinofine Sinofine changed the title activity embedding activity embedding (android 12L) Feb 25, 2023
@SpiritCroc

SpiritCroc commented Mar 4, 2023

Copy link
Copy Markdown
Member

Thank you! On first glance looks great on emulator (my real tablet is still only A11...) 👍

Note to self: code resembles what's described here, so seems good: https://developer.android.com/guide/topics/large-screens/activity-embedding

Android Studio tells me there is a more recent -alpha06 for androirdx.window, though it doesn't compile as is when bumping the version, maybe some API changed? 🤔

Would it be hard to hide behind a feature flag? Testing on foldable emulator, I got duplicate "please verify" banners, and the navigation drawer is larger than the left activity, thus being cut when expanded. Both not too bad if we can make this a labs setting - otherwise dunno, maybe worth having a while in beta to detect and fix anything before getting it into a stable release.

@SpiritCroc

Copy link
Copy Markdown
Member

Oh, just wanted to test logging in, but noticed I can't even log out with this one, dialog is cut as well :/

Screenshot_2023-03-04_15-39-55

@Sinofine

Sinofine commented Mar 4, 2023

Copy link
Copy Markdown
Author

maybe it's better to add width of the left panel. The alpha06 version introduced several interface changes to the activity embedding.

when the device is wide enough, the logout dialog is okay.
Screenshot_20230304_235618_SchildiChat dbg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants