Skip to content
This repository was archived by the owner on Jul 13, 2025. It is now read-only.

fix: convert number IDs to BigInt#976

Draft
moltar wants to merge 1 commit into
masterfrom
fix/bigint
Draft

fix: convert number IDs to BigInt#976
moltar wants to merge 1 commit into
masterfrom
fix/bigint

Conversation

@moltar

@moltar moltar commented Aug 5, 2022

Copy link
Copy Markdown
Contributor

Convert all number identifiers to BigInt.

Closes: #975

@NishealJ

NishealJ commented Aug 7, 2022

Copy link
Copy Markdown
Contributor

@moltar we'll have to cover all the ids right? keywordId, adgroupId etc.
Also while sending a request to amazon we can send them as a string (but not sure if all the APIs accept them as String).

@moltar

moltar commented Aug 7, 2022

Copy link
Copy Markdown
Contributor Author

Ya that's the hardest part is to feed them ints back. Not sure if the api will accept strings. Need to experiment. However, it should be still possible to use some custom serialization method to convert stringified ints to proper ints. Even if it means just using a regex to strip off " from string json.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Amazon Apis sends campaignId as number/integer

2 participants