adding loading-indicator audio support#2
Merged
Merged
Conversation
Adds loading_audio config plus loading_start / loading_stop fire-and-forget WebSocket commands to node-sdk and python-sdk, mirroring the server addition in SaynaAI/sayna#18. Failures continue to surface through the existing registerOnError / register_on_error callbacks; no new error types are added. See ../sayna/docs/websocket.md#loading-indicator for the protocol contract.
The wrapped-exception branches are exercised by test_loading_start_wraps_send_failure and test_loading_stop_wraps_send_failure in python-sdk/tests/test_client.py. The pragma was copy-pasted from sip_transfer (which has no equivalent test) and incorrectly masked covered code from coverage tracking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds loading_audio config plus loading_start / loading_stop fire-and-forget WebSocket commands to node-sdk and python-sdk, mirroring the server addition in SaynaAI/sayna#18. Failures continue to surface through the existing registerOnError / register_on_error callbacks; no new error types are added.
See ../sayna/docs/websocket.md#loading-indicator for the protocol contract.