Add FE patch for Checkpoint 10#36
Open
nrkin wants to merge 2 commits into
Open
Conversation
nrkin
commented
Apr 5, 2023
nrkin
commented
Collaborator
- Divided into 4 tasks
-
- Get the correct values and setters
-
- Handle like / dislike UI
-
- Handle like / dislike XHR
-
- Handle disable / enable UI and state
+ Divided into 4 tasks + 1. Get the correct values and setters + 2. Handle like / dislike UI + 3. Handle like / dislike XHR + 4. Handle disable / enable UI and state
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
vishwagosalia
approved these changes
Apr 5, 2023
hs-saunved
reviewed
Apr 7, 2023
There was a problem hiding this comment.
Not sure why this patch is present in this checkpoint, please check/remove it
hs-saunved
approved these changes
Apr 7, 2023
hs-saunved
left a comment
hs-saunved
left a comment
There was a problem hiding this comment.
LGTM. Please check why three.patch is present in this checkpoint though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.