Skip to content

Create ja_jp.json for 26.1#11

Open
Abbage230 wants to merge 1 commit into
SathLabs:26.1from
Abbage230:patch-2
Open

Create ja_jp.json for 26.1#11
Abbage230 wants to merge 1 commit into
SathLabs:26.1from
Abbage230:patch-2

Conversation

@Abbage230

@Abbage230 Abbage230 commented May 23, 2026

Copy link
Copy Markdown

Summary by CodeRabbit

  • Localization
    • Added Japanese language support with translated strings for blocks, creative tab, items, keys, and tooltips including color and glowing-related properties.

Review Change Stack

@coderabbitai

coderabbitai Bot commented May 23, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

Adds Japanese language localization file for the Luminax mod, providing translated strings for blocks, items, creative tab labels, keybind descriptions, and UI tooltips including color selection and glowing properties.

Changes

Japanese Localization

Layer / File(s) Summary
Japanese locale definitions
src/main/resources/assets/luminax/lang/ja_jp.json
Complete Japanese translation file with localized keys for Luminax blocks, items, keybinds, creative tab, and UI tooltips describing color and glowing behavior.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A file in nihongo blooms,
Translations fill the pixel rooms,
Glowing blocks in Japanese glow,
Luminax now speaks, row by row!
光の言葉、完成しぬ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: adding a Japanese localization file (ja_jp.json) for the 26.1 release version.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/main/resources/assets/luminax/lang/ja_jp.json`:
- Around line 16-17: The two Japanese tooltip entries tooltip.luminax.glowing.on
and tooltip.luminax.glowing.off are identical; update the .off entry to clearly
indicate disabling glowing (e.g., change tooltip.luminax.glowing.off to
"ブロックの発光を停止します") while keeping tooltip.luminax.glowing.on as the enabling
message ("ブロックが光を発するようにします"); this mirrors the intended pair TOOLTIP_GLOWING_ON
/ TOOLTIP_GLOWING_OFF used in LXLanguage.java.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: c98a942c-1ffa-463b-8651-377152c38c88

📥 Commits

Reviewing files that changed from the base of the PR and between 00d446e and ec5750d.

📒 Files selected for processing (1)
  • src/main/resources/assets/luminax/lang/ja_jp.json

Comment on lines +16 to +17
"tooltip.luminax.glowing.off": "ブロックが光を発するようにします",
"tooltip.luminax.glowing.on": "ブロックが光を発するようにします",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Identical tooltips for glowing on and off states.

Both tooltip.luminax.glowing.off and tooltip.luminax.glowing.on have the same translation: "ブロックが光を発するようにします" (Makes the block emit light). This appears to be inherited from the English source in LXLanguage.java, where both states also have identical text.

The .off tooltip should describe turning glowing off (e.g., "ブロックの発光を停止します" - Stops the block from emitting light), while the .on tooltip describes turning it on.

💡 Suggested fix for clarity
- "tooltip.luminax.glowing.off": "ブロックが光を発するようにします",
+ "tooltip.luminax.glowing.off": "ブロックの発光を停止します",
  "tooltip.luminax.glowing.on": "ブロックが光を発するようにします",

As per context snippet from LXLanguage.java:17-49, the English source also has this inconsistency where both TOOLTIP_GLOWING_ON and TOOLTIP_GLOWING_OFF use "Makes the block emit light".

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"tooltip.luminax.glowing.off": "ブロックが光を発するようにします",
"tooltip.luminax.glowing.on": "ブロックが光を発するようにします",
"tooltip.luminax.glowing.off": "ブロックの発光を停止します",
"tooltip.luminax.glowing.on": "ブロックが光を発するようにします",
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/main/resources/assets/luminax/lang/ja_jp.json` around lines 16 - 17, The
two Japanese tooltip entries tooltip.luminax.glowing.on and
tooltip.luminax.glowing.off are identical; update the .off entry to clearly
indicate disabling glowing (e.g., change tooltip.luminax.glowing.off to
"ブロックの発光を停止します") while keeping tooltip.luminax.glowing.on as the enabling
message ("ブロックが光を発するようにします"); this mirrors the intended pair TOOLTIP_GLOWING_ON
/ TOOLTIP_GLOWING_OFF used in LXLanguage.java.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant