[6.19.z] Fix host_conf to resolve post_configs from content_host settings #22077
Open
Gauravtalreja1 wants to merge 1 commit into
Open
[6.19.z] Fix host_conf to resolve post_configs from content_host settings #22077Gauravtalreja1 wants to merge 1 commit into
Gauravtalreja1 wants to merge 1 commit into
Conversation
…elliteQE#22065) host_conf() was reading post_configs from request.param (never set by fixture_markers), instead of the version's YAML config, so FIPS variants like rhel7_fips never ran their enable-fips post-deploy action. Track applied post-configs on host object via _post_deploy_config attribute Also fixes a dict aliasing issue (conf = params = {}), and migrates rhel_contenthost_with_repos and module_flatpak_contenthost to use contenthost_factory so all content host fixtures consistently handle post_configs. Signed-off-by: Gaurav Talreja <gtalreja@redhat.com> (cherry picked from commit 497bf6b)
Gauravtalreja1
added
No-CherryPick
Gauravtalreja1
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failed Autocherrypick of #22065
Fixes #22073
Problem Statement
Currently,
host_conf()reads post_configs fromrequest.param, which fixture_markers never populates. This means post_configs defined in conf/content_host.yaml (e.g., post_configs: [fips] for rhel7_fips) are silently ignored, the enable-fips workflow never runs for FIPS content hosts that rely on it.Additionally, host_conf() has a dict aliasing bug (conf = params = {}) that mutates request.param as a side effect, and two fixtures (rhel_contenthost_with_repos, module_flatpak_contenthost) bypass contenthost_factory, so they would never handle post-configs even if host_conf returned them correctly.
Solution
Related Issues
Follow-up of #16981