Change Owner/Org/Loc test coverage - #19030
Merged
vsedmik merged 3 commits intoJul 24, 2025
Merged
Conversation
LadislavVasina1
requested review from
ColeHiggins2,
pnovotny,
pondrejk,
sambible,
vijaysawant and
vsedmik
July 21, 2025 09:48
Contributor
Author
|
Collaborator
|
PRT Result |
This was referenced Jul 21, 2025
vsedmik
approved these changes
Jul 21, 2025
vsedmik
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, nice work!
vijaysawant
reviewed
Jul 21, 2025
| session.organization.select(org_name=module_org.name) | ||
| session.location.select(loc_name=module_location.name) | ||
|
|
||
| # Change the hosts' owner to the new user |
Contributor
There was a problem hiding this comment.
Suggested change
| # Change the hosts' owner to the new user | |
| # Change the host's owner to the new user |
Contributor
Author
There was a problem hiding this comment.
vijaysawant
reviewed
Jul 21, 2025
| 'Owner': True, | ||
| } | ||
| ) | ||
| # Change the hosts' owner to the user group |
Contributor
There was a problem hiding this comment.
Suggested change
| # Change the hosts' owner to the user group | |
| # Change the host's owner to the user group |
Contributor
Author
There was a problem hiding this comment.
vijaysawant
reviewed
Jul 21, 2025
vijaysawant
reviewed
Jul 21, 2025
| 2. Create/Register multiple content hosts in the first organization/location | ||
| 3. Navigate to All Hosts page | ||
| 4. Select multiple hosts | ||
| 5. Use bulk action to change organization and location |
Contributor
There was a problem hiding this comment.
Suggested change
| 5. Use bulk action to change organization and location | |
| 5. Use bulk action to change organization/location |
vijaysawant
reviewed
Jul 21, 2025
vijaysawant
reviewed
Jul 21, 2025
vijaysawant
approved these changes
Jul 21, 2025
vijaysawant
left a comment
Contributor
There was a problem hiding this comment.
Talking about test_positive_change_hosts_org_loc, so there is scope of improvement, but I would say we should get atleast one positive scenario in, in later part of this feature we could add more scenarios (option = fail on mismatch)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds 2 new tests:
test_positive_change_hosts_ownercoverage forchange the owner of multiple hosts(https://issues.redhat.com/browse/SAT-31026)test_positive_change_hosts_org_loccoverage forchange the location and organization of multiple hosts(https://issues.redhat.com/browse/SAT-31030)(@vijaysawant needed a backup with finishing the robottelo coverage for this feature, so the test is inspired and refactored from this PR https://github.com/SatelliteQE/robottelo/pull/18980/files)
Additional info
Needs Airgun: SatelliteQE/airgun#1933
Needs upstream foreman: theforeman/foreman#10591
PRT example