Disassociate Hosts Coverage [SAT-31029] - #18859
Merged
vsedmik merged 5 commits intoJul 8, 2025
Merged
Conversation
LadislavVasina1
requested review from
a team,
ColeHiggins2,
Gauravtalreja1,
chris1984 and
vijaysawant
July 1, 2025 10:16
Contributor
Author
|
Collaborator
|
PRT Result |
pondrejk
approved these changes
Jul 1, 2025
vijaysawant
requested changes
Jul 1, 2025
Contributor
Author
|
Collaborator
|
PRT Result |
Contributor
Author
|
Collaborator
|
PRT Result |
Contributor
Author
|
It seems that the PRT is failing due to selenium UI session is obfuscated by the breached password warning; for more reference, see 1.7.2025 JPL meeting notes. (PRT managed to pass at least once ath the beginning here #18859 (comment)) |
pnovotny
requested changes
Jul 7, 2025
Contributor
Author
|
@pnovotny, thank you for the suggestions, I will push the changes in a minute |
Contributor
Author
vsedmik
approved these changes
Jul 8, 2025
vsedmik
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, great work!
I put only one non-blocking nit bellow.
| cv.publish() | ||
|
|
||
| # create hostgroup | ||
| hostgroup_name = gen_string('alpha') |
Contributor
There was a problem hiding this comment.
This is the second definition of hostgroup_name. I would just remove the one from line 3021 and keep this one.
Contributor
Author
There was a problem hiding this comment.
@vsedmik True, thanks for that, I missed this.
vsedmik
enabled auto-merge (squash)
July 8, 2025 07:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem Statement
There is a new feature that enables users to disassociate multiple hosts via the All Hosts page. (SAT-31029)
Solution
Create a test
test_disassociate_multiple_hoststhat covers this use case.It creates a VMware compute resource, imports 2 VMs,
(Thank you @Gauravtalreja1 for the info on how to do that, this part of the test is inspired by
test_positive_virt_card)and disassociates them via the UI.
Checks that the disassociation went well are done via the API, and they are checking values based on this https://github.com/theforeman/foreman/blob/f4246cdaca1d0039d93de65cda9e52862c02f81b/app/models/host/managed.rb#L589
Related Issues
Needs:
SatelliteQE/airgun#1909
theforeman/foreman#10560
PRT test Cases example