fix(svelte): Silence baseUrl TS5101 deprecation with ignoreDeprecations#185
Merged
Conversation
TypeScript now emits TS5101 for the deprecated 'baseUrl' compiler option. svelte-preprocess treats the diagnostic as fatal, which broke the svelte build and svelte-check, cascading to all PR Checks jobs (Tests / Build / Lint + Typecheck). The other package tsconfigs (core/react/solid/vue/website) already set "ignoreDeprecations": "6.0" for this; packages/svelte was the only one missing it. Add the same option to restore CI.
starlight-links-validator is incompatible with Astro 7's new markdown processor, which throws 'The configured markdown.processor is not supported' during astro build and fails the website#lint CI job. Upstream has no Astro 7-compatible release yet (HiDeoo/starlight-links-validator#165). Detect the Astro major version at config time and skip the validator on Astro >= 7. Link validation returns automatically once upstream ships a fix and Astro is still on a supported major.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all failing PR Checks that were blocking every open Dependabot PR. Two independent root causes; both fixed here.
1. Svelte build/typecheck —
TS5101baseUrl deprecationTypeScript now emits
TS5101for the deprecatedbaseUrlcompiler option:svelte-preprocesstreats that diagnostic as fatal, breaking the svelte build andsvelte-checkand cascading to the Build and Tests jobs.packages/svelte/tsconfig.jsonwas the only package tsconfig missing"ignoreDeprecations": "6.0"—core,react,solid,vue,websitealready had it.Fix: add
"ignoreDeprecations": "6.0"topackages/svelte/tsconfig.json.2. Website lint — Astro 7 / starlight-links-validator incompatibility
The Lint + Typecheck job failed in
website#lint:PR #167 bumped Astro 6.4.8 → 7.0.2.
starlight-links-validator@0.24.1(latest) is not Astro 7-compatible — upstream issue #165 is open with no fix released.Fix: detect the Astro major version in
astro.config.mjsand skipstarlight-links-validatoron Astro ≥ 7. Link validation returns automatically once upstream ships an Astro 7-compatible release.Verification (Node 22.x, matching CI)
svelte-check→ 0 errors, 0 warningsbuild(turbo build --filter='./packages/*') → 5/5 packages, all dist dirs presentlint-typecheck(turbolint typecheck) → all packages + website pass举一反三 (generalization)
tsconfig.json. All package + website tsconfigs now consistently set"ignoreDeprecations": "6.0".examples/*/tsconfig*.jsonalso usebaseUrl, but examples are outside CI'sbuild/typecheckscope (run-checks.mjsonly builds./packages/*), so they don't block CI.mainand they re-run checks.Out of scope (not addressed — flagged for awareness)
scripts/tasks/postbuild-svelte.mjs:100usesfs.rmdirSync(path, { recursive: true }), deprecated as a warning on Node 22 (CI) but fatal on Node ≥ 25. Switching tofs.rmSync(path, { recursive: true })is a proactive improvement, not a current CI failure.