✨ Surface remaining v5 resources: ads, product-pages, budget-orders, auth orgs (Phases 2-4)#34
Merged
Merged
Conversation
Surface two v5 creative-management resources (read-only): - asa ads list/get — view ads within an ad group - asa product-pages — list/get custom product pages (CPP) and per-locale details (locales) Ads are read-only: v5 ad creation is tied to product pages and creative sets, out of scope for this pass. Phase 2 of #32.
Surface the v5 budget orders resource: - asa budget-orders list — list budget orders (budget, status, dates) - asa budget-orders get — show a single budget order Note: the generic custom-reports endpoint is intentionally not surfaced — Apple disabled GET /custom-reports (403) in March 2026 in favour of the Insights tool, so the existing impression-share POST/poll flow remains the working path. Phase 3 of #32.
Surface the v5 ACL resource via 'asa auth orgs', listing the organizations the configured credentials can access (org ID, name, currency, roles, time zone). Useful for finding the ASA_ORG_ID to use in multi-org setups. Phase 4 of #32.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes #32 (Phases 2–4) — surfaces the remaining reachable v5 resources from
asa-api-clientas CLI commands. Builds on Phase 1 (#33). Delivered as three logical commits, one per phase.New commands
Phase 2 — creative management (read-only)
asa ads list -c <campaign> -a <ad-group>campaigns().ad_groups().ads.listasa ads get <id> -c <campaign> -a <ad-group>…ads.getasa product-pages listproduct_pages.listasa product-pages get <id>product_pages.getasa product-pages locales <id>product_pages.get_locale_detailsPhase 3 — billing
asa budget-orders listbudget_orders.listasa budget-orders get <id>budget_orders.getPhase 4 — org access
asa auth orgsacls.listAll support
--format table\|json\|csvand follow existing typer/utilsconventions.Deliberate scope decisions
adsis read-only. v5 ad creation is tied to product pages / creative sets — out of scope for a surfacing pass. (Flagged as a scope guard in ✨ Surface remaining v5 API resources as CLI commands #32.)custom-reportscommand. Thecustom_reportsresource is the impression-share API, and itsGET /custom-reportsendpoint returns 403 (disabled by Apple since March 2026) in favour of the Insights tool. The working POST/poll flow is already exposed via theimpression-sharegroup, so adding a dead endpoint was intentionally avoided.Verification
ruff check/ruff format --checkmypy --strict(19 source files)pytest— 11 passed (help/registration tests for each new group)Closes #32.